Send OnModifyFile Notification when File Write Finishes

webkit/fileapi/local_file_system_operation.cc

Index: webkit/fileapi/local_file_system_operation.cc
diff --git a/webkit/fileapi/local_file_system_operation.cc b/webkit/fileapi/local_file_system_operation.cc
index ff46be532199a57d370f4c7b080206d6aa826091..797ae38b70d3c0b1a5bc3b974e8698a8c0e2a725 100644
--- a/webkit/fileapi/local_file_system_operation.cc
+++ b/webkit/fileapi/local_file_system_operation.cc
@@ -314,7 +314,7 @@ void LocalFileSystemOperation::Write(
   DCHECK(blob_url.is_valid());
   file_writer_delegate_.reset(new FileWriterDelegate(
       base::Bind(&LocalFileSystemOperation::DidWrite,
-                 weak_factory_.GetWeakPtr()),
+                 weak_factory_.GetWeakPtr(), url),
       writer.Pass()));
 
   set_write_callback(callback);
@@ -677,6 +677,7 @@ void LocalFileSystemOperation::DidReadDirectory(
 }
 
 void LocalFileSystemOperation::DidWrite(
+    const FileSystemURL& url,
     base::PlatformFileError rv,
     int64 bytes,
     bool complete) {
@@ -686,6 +687,12 @@ void LocalFileSystemOperation::DidWrite(
     delete this;
     return;
   }
+
+  if (complete) {
+    operation_context_->change_observers()->Notify(
+        &FileChangeObserver::OnModifyFile, MakeTuple(url));

[kinuko, 2012/09/25 04:12:26]

On the second thought (and on the contrary to what I said), can we try not to
fire ModifyFile when we failed before starting to write anything?

I think we can keep a writing status in WriterDelegate, not necessarily as a
total_bytes_writtenbn format but may be a boolean or an enum status flag (we
generally prefer enum than boolean) which could be either
WRITER_DELEGATE_STATE_INIT or WRITING.

To propagate the delegate's status we could add another parameter to
WriterDelegate::DidWrite but just passing a special value (i.e -1) would also
work.

+  }
+
   write_callback_.Run(rv, bytes, complete);
   if (complete || rv != base::PLATFORM_FILE_OK)
     delete this;