Send OnModifyFile Notification when File Write Finishes

webkit/fileapi/local_file_system_operation_write_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
 #include "base/scoped_temp_dir.h"
 #include "googleurl/src/gurl.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_job.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/blob/blob_data.h"
 #include "webkit/blob/blob_storage_controller.h"
 #include "webkit/blob/blob_url_request_job.h"
 #include "webkit/fileapi/file_system_context.h"
 #include "webkit/fileapi/file_system_file_util.h"
 #include "webkit/fileapi/file_system_util.h"
 #include "webkit/fileapi/local_file_system_operation.h"
 #include "webkit/fileapi/local_file_system_test_helper.h"
 #include "webkit/fileapi/local_file_util.h"
+#include "webkit/fileapi/mock_file_change_observer.h"
+

[kinuko, 2012/09/25 14:00:49]

nit: extra empty line

[calvinlo, 2012/09/26 05:23:07]

Done.

 #include "webkit/quota/quota_manager.h"
 
 using quota::QuotaManager;
 
 namespace fileapi {
 
 namespace {
 
 void AssertStatusEq(base::PlatformFileError expected,
                     base::PlatformFileError actual) {
@@ skipping 32 matching lines @@
 class LocalFileSystemOperationWriteTest
     : public testing::Test,
       public base::SupportsWeakPtr<LocalFileSystemOperationWriteTest> {
  public:
   LocalFileSystemOperationWriteTest()
       : test_helper_(GURL("http://example.com"), kFileSystemTypeTest),
         loop_(MessageLoop::TYPE_IO),
         status_(base::PLATFORM_FILE_OK),
         cancel_status_(base::PLATFORM_FILE_ERROR_FAILED),
         bytes_written_(0),
-        complete_(false) {}
+        complete_(false) {
+    change_observers_ = MockFileChangeObserver::CreateList(&change_observer_);
+  }
 
   LocalFileSystemOperation* operation();
 
   base::PlatformFileError status() const { return status_; }
   base::PlatformFileError cancel_status() const { return cancel_status_; }
   void add_bytes_written(int64 bytes, bool complete) {
     bytes_written_ += bytes;
     EXPECT_FALSE(complete_);
     complete_ = complete;
   }
   int64 bytes_written() const { return bytes_written_; }
   bool complete() const { return complete_; }
 
   virtual void SetUp();
   virtual void TearDown();
 
  protected:
+  const ChangeObserverList& change_observers() const {
+    return change_observers_;
+  }
+
+  MockFileChangeObserver* change_observer() {
+    return &change_observer_;
+  }
+
   FileSystemURL URLForPath(const FilePath& path) const {
     return test_helper_.CreateURL(path);
   }
 
   // Callback function for recording test results.
   FileSystemOperation::WriteCallback RecordWriteCallback() {
     return base::Bind(&LocalFileSystemOperationWriteTest::DidWrite,
                       AsWeakPtr());
   }
 
@@ skipping 33 matching lines @@
   ScopedTempDir dir_;
   FilePath virtual_path_;
 
   // For post-operation status.
   base::PlatformFileError status_;
   base::PlatformFileError cancel_status_;
   int64 bytes_written_;
   bool complete_;
 
   DISALLOW_COPY_AND_ASSIGN(LocalFileSystemOperationWriteTest);
+
+ private:
+  MockFileChangeObserver change_observer_;
+  ChangeObserverList change_observers_;
 };
 
 namespace {
 
 class TestProtocolHandler : public net::URLRequestJobFactory::ProtocolHandler {
  public:
   explicit TestProtocolHandler(
       webkit_blob::BlobStorageController* blob_storage_controller)
       : blob_storage_controller_(blob_storage_controller) {}
 
@@ skipping 55 matching lines @@
       URLForPath(virtual_path_), true /* exclusive */,
       base::Bind(&AssertStatusEq, base::PLATFORM_FILE_OK));
 }
 
 void LocalFileSystemOperationWriteTest::TearDown() {
   quota_manager_ = NULL;
   test_helper_.TearDown();
 }
 
 LocalFileSystemOperation* LocalFileSystemOperationWriteTest::operation() {
-  return test_helper_.NewOperation();
+  LocalFileSystemOperation* operation = test_helper_.NewOperation();
+  operation->operation_context()->set_change_observers(change_observers());
+  return operation;
 }
 
 TEST_F(LocalFileSystemOperationWriteTest, TestWriteSuccess) {
   GURL blob_url("blob:success");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("Hello, world!\n");
 
   TestURLRequestContext url_request_context;
   url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   operation()->Write(&url_request_context, URLForPath(virtual_path_), blob_url,
                      0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
   url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(14, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_OK, status());
   EXPECT_TRUE(complete());
+
+  EXPECT_EQ(1, change_observer()->get_and_reset_modify_file_count());
 }
 
 TEST_F(LocalFileSystemOperationWriteTest, TestWriteZero) {
   GURL blob_url("blob:zero");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
 
   TestURLRequestContext url_request_context;
   url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   operation()->Write(&url_request_context, URLForPath(virtual_path_),
                      blob_url, 0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
   url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_OK, status());
   EXPECT_TRUE(complete());
+
+  EXPECT_EQ(1, change_observer()->get_and_reset_modify_file_count());
 }
 
 TEST_F(LocalFileSystemOperationWriteTest, TestWriteInvalidBlobUrl) {
   TestURLRequestContext url_request_context;
 
   operation()->Write(&url_request_context, URLForPath(virtual_path_),
       GURL("blob:invalid"), 0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_FAILED, status());
   EXPECT_TRUE(complete());
+
+  EXPECT_EQ(0, change_observer()->get_and_reset_modify_file_count());
 }
 
 TEST_F(LocalFileSystemOperationWriteTest, TestWriteInvalidFile) {
   GURL blob_url("blob:writeinvalidfile");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("It\'ll not be written.");
 
   TestURLRequestContext url_request_context;
   url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   operation()->Write(&url_request_context,
                      URLForPath(FilePath(FILE_PATH_LITERAL("nonexist"))),
                      blob_url, 0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
   url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_NOT_FOUND, status());
   EXPECT_TRUE(complete());
+
+  EXPECT_EQ(1, change_observer()->get_and_reset_modify_file_count());
 }
 
 TEST_F(LocalFileSystemOperationWriteTest, TestWriteDir) {
   FilePath virtual_dir_path(FILE_PATH_LITERAL("d"));
   operation()->CreateDirectory(
       URLForPath(virtual_dir_path),
       true /* exclusive */, false /* recursive */,
       base::Bind(&AssertStatusEq, base::PLATFORM_FILE_OK));
 
   GURL blob_url("blob:writedir");
@@ skipping 10 matching lines @@
 
   url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(0, bytes_written());
   // TODO(kinuko): This error code is platform- or fileutil- dependent
   // right now.  Make it return PLATFORM_FILE_ERROR_NOT_A_FILE in every case.
   EXPECT_TRUE(status() == base::PLATFORM_FILE_ERROR_NOT_A_FILE ||
               status() == base::PLATFORM_FILE_ERROR_ACCESS_DENIED ||
               status() == base::PLATFORM_FILE_ERROR_FAILED);
   EXPECT_TRUE(complete());
+
+  EXPECT_EQ(1, change_observer()->get_and_reset_modify_file_count());
 }
 
 TEST_F(LocalFileSystemOperationWriteTest, TestWriteFailureByQuota) {
   GURL blob_url("blob:success");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("Hello, world!\n");
 
   TestURLRequestContext url_request_context;
   url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   quota_manager_->set_quota(10);
   operation()->Write(&url_request_context, URLForPath(virtual_path_), blob_url,
                      0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
   url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(10, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_NO_SPACE, status());
   EXPECT_TRUE(complete());
+
+  EXPECT_EQ(1, change_observer()->get_and_reset_modify_file_count());
 }
 
 TEST_F(LocalFileSystemOperationWriteTest, TestImmediateCancelSuccessfulWrite) {
   GURL blob_url("blob:success");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("Hello, world!\n");
 
   TestURLRequestContext url_request_context;
   url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   FileSystemOperation* write_operation = operation();
   write_operation->Write(&url_request_context, URLForPath(virtual_path_),
                          blob_url, 0, RecordWriteCallback());
   write_operation->Cancel(RecordCancelCallback());
   // We use RunAllPendings() instead of Run() here, because we won't dispatch
   // callbacks after Cancel() is issued (so no chance to Quit) nor do we need
   // to run another write cycle.
   MessageLoop::current()->RunAllPending();
 
   url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   // Issued Cancel() before receiving any response from Write(),
   // so nothing should have happen.
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_ABORT, status());
   EXPECT_EQ(base::PLATFORM_FILE_OK, cancel_status());
   EXPECT_TRUE(complete());
+
+  EXPECT_EQ(0, change_observer()->get_and_reset_modify_file_count());
 }
 
 TEST_F(LocalFileSystemOperationWriteTest, TestImmediateCancelFailingWrite) {
   GURL blob_url("blob:writeinvalidfile");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("It\'ll not be written.");
 
   TestURLRequestContext url_request_context;
   url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   FileSystemOperation* write_operation = operation();
   write_operation->Write(&url_request_context,
                          URLForPath(FilePath(FILE_PATH_LITERAL("nonexist"))),
                          blob_url, 0, RecordWriteCallback());
   write_operation->Cancel(RecordCancelCallback());
   // We use RunAllPendings() instead of Run() here, because we won't dispatch
   // callbacks after Cancel() is issued (so no chance to Quit) nor do we need
   // to run another write cycle.
   MessageLoop::current()->RunAllPending();
 
   url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   // Issued Cancel() before receiving any response from Write(),
   // so nothing should have happen.
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_ABORT, status());
   EXPECT_EQ(base::PLATFORM_FILE_OK, cancel_status());
   EXPECT_TRUE(complete());
+
+  EXPECT_EQ(0, change_observer()->get_and_reset_modify_file_count());
 }
 
 // TODO(ericu,dmikurube,kinuko): Add more tests for cancel cases.
 
 }  // namespace fileapi