Issue 10952: More *.scons renaming:...

Issue 10952: More *.scons renaming:... (Closed)

Created:
12 years, 1 month ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

More *.scons renaming: * Rename SConscript to *.scons in the following directories: third_party\{bspatch,bsdiff,lzma_dsk} chrome\installer\{setup,mini_installer,util} * Split mini_installer and installer_unittests into separate *.scons files. * Add using_bspatch.scons and using_lzma_sdk.scons "properties" files, modifying other *.scons files to use them as appropriate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5515

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -817 lines)			Patch
M	build/SConscript.main	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/SConscript	View		1 chunk	+4 lines, -3 lines	0 comments	Download
D	chrome/installer/mini_installer/SConscript	View		1 chunk	+0 lines, -160 lines	0 comments	Download
A	chrome/installer/mini_installer/installer_unittests.scons	View	1	1 chunk	+68 lines, -0 lines	0 comments	Download
A +	chrome/installer/mini_installer/mini_installer.scons	View		2 chunks	+62 lines, -116 lines	0 comments	Download
D	chrome/installer/setup/SConscript	View		1 chunk	+0 lines, -87 lines	0 comments	Download
A +	chrome/installer/setup/setup.scons	View		3 chunks	+42 lines, -44 lines	0 comments	Download
D	chrome/installer/util/SConscript	View		1 chunk	+0 lines, -77 lines	0 comments	Download
A +	chrome/installer/util/util.scons	View		2 chunks	+13 lines, -24 lines	0 comments	Download
D	third_party/bsdiff/SConscript	View		1 chunk	+0 lines, -53 lines	0 comments	Download
A +	third_party/bsdiff/bsdiff.scons	View		1 chunk	+6 lines, -34 lines	0 comments	Download
D	third_party/bspatch/SConscript	View		1 chunk	+0 lines, -64 lines	0 comments	Download
A +	third_party/bspatch/bspatch.scons	View		2 chunks	+11 lines, -45 lines	0 comments	Download
A	third_party/bspatch/using_bspatch.scons	View		1 chunk	+18 lines, -0 lines	0 comments	Download
D	third_party/lzma_sdk/SConscript	View		1 chunk	+0 lines, -72 lines	0 comments	Download
A +	third_party/lzma_sdk/lzma_sdk.scons	View		1 chunk	+5 lines, -31 lines	0 comments	Download
A	third_party/lzma_sdk/using_lzma_sdk.scons	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/10952/diff/1/16 File chrome/installer/mini_installer/installer_unittests.scons (right): http://codereview.chromium.org/10952/diff/1/16#newcode15 Line 15: env['LIBS'].remove('DelayImp.lib') Nit: Is this windows specific?

12 years, 1 month ago (2008-11-14 19:37:44 UTC) #2

sgk

12 years, 1 month ago (2008-11-14 21:15:17 UTC) #3

http://codereview.chromium.org/10952/diff/1/16
File chrome/installer/mini_installer/installer_unittests.scons (right):

http://codereview.chromium.org/10952/diff/1/16#newcode15
Line 15: env['LIBS'].remove('DelayImp.lib')
On 2008/11/14 19:37:45, tony wrote:
> Nit: Is this windows specific?

Done.

Expand Messages | Collapse Messages