Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10951029: Removes PluginInfoMessageFilter dependency on PluginGroup. (Closed)

Created:
8 years, 3 months ago by ibraaaa
Modified:
8 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removes PluginInfoMessageFilter dependency on PluginGroup. BUG=124396 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157966

Patch Set 1 #

Patch Set 2 : merge conflict #

Patch Set 3 : fixed conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -84 lines) Patch
M chrome/browser/renderer_host/plugin_info_message_filter.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/plugin_info_message_filter.cc View 1 2 4 chunks +21 lines, -37 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 9 chunks +23 lines, -29 lines 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
ibraaaa
8 years, 3 months ago (2012-09-19 13:45:12 UTC) #1
Bernhard Bauer
LGTM Just so I understand, this is essentially a re-land of http://crrev.com/155529, right?
8 years, 3 months ago (2012-09-20 17:09:02 UTC) #2
ibraaaa
Yes. On 2012/09/20 17:09:02, Bernhard Bauer wrote: > LGTM > > Just so I understand, ...
8 years, 3 months ago (2012-09-20 17:13:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10951029/1
8 years, 3 months ago (2012-09-20 17:14:56 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/renderer/chrome_content_renderer_client.cc: While running patch -p1 --forward --force; patching file chrome/renderer/chrome_content_renderer_client.cc ...
8 years, 3 months ago (2012-09-20 17:14:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10951029/10001
8 years, 3 months ago (2012-09-20 17:30:13 UTC) #6
commit-bot: I haz the power
Presubmit check for 10951029-10001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-20 17:30:16 UTC) #7
ibraaaa
Hi James, Can I have an OWNERS review for this CL?
8 years, 3 months ago (2012-09-20 17:34:25 UTC) #8
James Hawkins
lgtm
8 years, 3 months ago (2012-09-20 17:36:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10951029/10001
8 years, 3 months ago (2012-09-20 17:38:43 UTC) #10
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 3 months ago (2012-09-20 18:44:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10951029/13003
8 years, 3 months ago (2012-09-21 08:56:51 UTC) #12
commit-bot: I haz the power
Retried try job too often for step(s) crypto_unittests, unit_tests, cacheinvalidation_unittests, remoting_unittests, jingle_unittests, nacl_integration, ipc_tests, interactive_ui_tests, ...
8 years, 3 months ago (2012-09-21 09:48:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10951029/13003
8 years, 3 months ago (2012-09-21 10:44:38 UTC) #14
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 12:53:07 UTC) #15
Change committed as 157966

Powered by Google App Engine
This is Rietveld 408576698