Fixed bugs in GPU process startup on POSIX platforms. Added...

Fixed bugs in GPU process startup on POSIX platforms. Added
--gpu-startup-dialog command line option to allow debugging of GPU
process.

BUG=none
TEST=none (tested manually in development workspace)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42375

[Ken Russell (switch to Gerrit), 2010-03-19 21:40:37]

Please review. Thanks.

[brettw, 2010-03-22 22:14:40]

http://codereview.chromium.org/1095005/diff/1/5
File chrome/gpu/gpu_main.cc (right):

http://codereview.chromium.org/1095005/diff/1/5#newcode34
chrome/gpu/gpu_main.cc:34: ChildProcess::WaitForDebugger(L"Gpu");
This doesn't seem right. We have "startup dialog" which displays a message box
for you to manually attach to a renderer. But the analog for what you've done
here is the 
--wait-for-debugger-children described here:
http://www.chromium.org/developers/how-tos/debugging

It seems like it would be better to re-use that and add a new filter type than
create a new one.

[Ken Russell (switch to Gerrit), 2010-03-22 22:53:46]

On 2010/03/22 22:14:40, brettw wrote:
> http://codereview.chromium.org/1095005/diff/1/5
> File chrome/gpu/gpu_main.cc (right):
> 
> http://codereview.chromium.org/1095005/diff/1/5#newcode34
> chrome/gpu/gpu_main.cc:34: ChildProcess::WaitForDebugger(L"Gpu");
> This doesn't seem right. We have "startup dialog" which displays a message box
> for you to manually attach to a renderer. But the analog for what you've done
> here is the 
> --wait-for-debugger-children described here:
> http://www.chromium.org/developers/how-tos/debugging
> 
> It seems like it would be better to re-use that and add a new filter type than
> create a new one.

It looks like the infrastructure for --wait-for-debugger-children=[type] is
broken. I just tried to implement it for the GPU process and then tried it for
the renderer and neither work.

I've personally only used the --renderer-startup-dialog and
--plugin-startup-dialog flags for debugging to date. There is also some
precedent for adding a new startup dialog flag; the renderer, plugin, and NaCl
sub-process types all support it.

I'd appreciate being able to commit these changes as they are and work more on
the issue later as desired.

[brettw, 2010-03-22 23:25:14]

LGTM, Ken pointed out this behavior matches the other platforms.

[Ken Russell (switch to Gerrit), 2010-03-23 00:14:15]

On 2010/03/22 23:25:14, brettw wrote:
> LGTM, Ken pointed out this behavior matches the other platforms.

Filed cleanup bug http://crbug.com/38974 about this.