Clamp the max size of fonts used by skia/chrome canvas.

Clamp the max size of fonts used by skia/chrome canvas.

This forces us to ignore dpi sizes > 96., like we do in other
places.  It does allow smaller DPIs to work since that mostly
just makes fonts smaller.

BUG=26354
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42311

[Evan Martin, 2010-03-19 04:56:56]

LGTM, I guess Elliot might have something more intelligent to say :)

http://codereview.chromium.org/1095004/diff/1/3
File app/gfx/font_gtk.cc (right):

http://codereview.chromium.org/1095004/diff/1/3#newcode65
app/gfx/font_gtk.cc:65: scale_factor = std::min(scale_factor, 96.f);
This is the new code, right?

[tony, 2010-03-19 04:59:35]

http://codereview.chromium.org/1095004/diff/1/3
File app/gfx/font_gtk.cc (right):

http://codereview.chromium.org/1095004/diff/1/3#newcode65
app/gfx/font_gtk.cc:65: scale_factor = std::min(scale_factor, 96.f);
On 2010/03/19 04:56:56, Evan Martin wrote:
> This is the new code, right?

Yes.

[Elliot Glaysher, 2010-03-19 05:06:26]

On 2010/03/19 04:59:35, tony wrote:
> http://codereview.chromium.org/1095004/diff/1/3
> File app/gfx/font_gtk.cc (right):
> 
> http://codereview.chromium.org/1095004/diff/1/3#newcode65
> app/gfx/font_gtk.cc:65: scale_factor = std::min(scale_factor, 96.f);
> On 2010/03/19 04:56:56, Evan Martin wrote:
> > This is the new code, right?
> 
> Yes.

Does this solve (or mitigate) issue 22614? Otherwise, I have nothing insightful
to add.

[tony, 2010-03-19 05:18:00]

On 2010/03/19 05:06:26, Elliot Glaysher wrote:
> Does this solve (or mitigate) issue 22614? Otherwise, I have nothing
insightful
> to add.

Nope.  I'm pretty sure the only way out of that hole is to switch to a scaleable
UI.

[sky, 2010-03-23 20:33:32]

http://codereview.chromium.org/1095004/diff/1/3
File app/gfx/font_gtk.cc (right):

http://codereview.chromium.org/1095004/diff/1/3#newcode135
app/gfx/font_gtk.cc:135: font.FontSize() * PANGO_SCALE *
Font::GetPangoScaleFactor());
You also need to change Canvas::SetupPangoLayout otherwise we're not symmetrical
if we actually draw.