Shift "commit point" for when a download will no longer accept cancels.

content/browser/download/download_file.h

Index: content/browser/download/download_file.h
diff --git a/content/browser/download/download_file.h b/content/browser/download/download_file.h
index e707a26ca10607149db7f8e14d587451e6d20cb8..623e4c67f38a77ea1b149731aabf6dc5192815df 100644
--- a/content/browser/download/download_file.h
+++ b/content/browser/download/download_file.h
@@ -33,10 +33,10 @@ class CONTENT_EXPORT DownloadFile {
 
   virtual ~DownloadFile() {}
 
-  // If calculate_hash is true, sha256 hash will be calculated.
   // Returns DOWNLOAD_INTERRUPT_REASON_NONE on success, or a network
-  // error code on failure.
-  virtual DownloadInterruptReason Initialize() = 0;
+  // error code on failure.  Upon completion, |callback| will be
+  // called on the UI thread as per the comment above.
+  virtual content::DownloadInterruptReason Initialize() = 0;

[asanka, 2012/09/20 18:42:15]

Nit: No content:: namespace qualifier needed in content namespace.

[Randy Smith (Not in Mondays), 2012/09/21 21:58:01]

Done.

 
   // Rename the download file to |full_path|.  If that file exists and
   // |overwrite_existing_file| is false, |full_path| will be uniquified by
@@ -48,7 +48,8 @@ class CONTENT_EXPORT DownloadFile {
                       const RenameCompletionCallback& callback) = 0;
 
   // Detach the file so it is not deleted on destruction.
-  virtual void Detach() = 0;
+  // |callback| will be called on the UI thread after detach.
+  virtual void Detach(base::Closure callback) = 0;
 
   // Abort the download and automatically close the file.
   virtual void Cancel() = 0;