Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chromeos/dbus/shill_profile_client_unittest.cc

Issue 10949030: This converts the Shill clients to allow propagation of shill errors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Review changes Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_profile_client_unittest.cc
diff --git a/chromeos/dbus/shill_profile_client_unittest.cc b/chromeos/dbus/shill_profile_client_unittest.cc
index 898a9615b17bd6313288566c2b54adfd714bd3a2..2bff89ee7b9e023f20f1ce58422b96895d8f4787 100644
--- a/chromeos/dbus/shill_profile_client_unittest.cc
+++ b/chromeos/dbus/shill_profile_client_unittest.cc
@@ -12,6 +12,8 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
+using testing::_;
+
namespace chromeos {
namespace {
@@ -101,8 +103,11 @@ TEST_F(ShillProfileClientTest, GetProperties) {
base::Bind(&ExpectNoArgument),
response.get());
// Call method.
+ MockErrorCallback error_callback;
client_->GetProperties(dbus::ObjectPath(kDefaultProfilePath),
- base::Bind(&ExpectDictionaryValueResult, &value));
+ base::Bind(&ExpectDictionaryValueResultWithoutStatus,
+ &value),
+ error_callback.GetCallback());
// Run the message loop.
message_loop_.RunAllPending();
}
@@ -130,9 +135,13 @@ TEST_F(ShillProfileClientTest, GetEntry) {
base::Bind(&ExpectStringArgument, kExampleEntryPath),
response.get());
// Call method.
+ MockErrorCallback error_callback;
client_->GetEntry(dbus::ObjectPath(kDefaultProfilePath),
kExampleEntryPath,
- base::Bind(&ExpectDictionaryValueResult, &value));
+ base::Bind(&ExpectDictionaryValueResultWithoutStatus,
+ &value),
+ error_callback.GetCallback());
+ EXPECT_CALL(error_callback, Run(_, _)).Times(0);
// Run the message loop.
message_loop_.RunAllPending();
}
@@ -150,9 +159,15 @@ TEST_F(ShillProfileClientTest, DeleteEntry) {
base::Bind(&ExpectStringArgument, kExampleEntryPath),
response.get());
// Call method.
+ MockClosure mock_closure;
+ MockErrorCallback mock_error_callback;
client_->DeleteEntry(dbus::ObjectPath(kDefaultProfilePath),
kExampleEntryPath,
- base::Bind(&ExpectNoResultValue));
+ mock_closure.GetCallback(),
+ mock_error_callback.GetCallback());
+ EXPECT_CALL(mock_closure, Run()).Times(1);
+ EXPECT_CALL(mock_error_callback, Run(_, _)).Times(0);
+
// Run the message loop.
message_loop_.RunAllPending();
}

Powered by Google App Engine
This is Rietveld 408576698