This converts the Shill clients to allow propagation of shill errors

chromeos/dbus/shill_client_unittest_base.h

Index: chromeos/dbus/shill_client_unittest_base.h
diff --git a/chromeos/dbus/shill_client_unittest_base.h b/chromeos/dbus/shill_client_unittest_base.h
index 1c56a17d3bb719d835f2bc5b7916bf3861ff16e8..f992091b6dca67f3fa663993ffbefa7bebf1d641 100644
--- a/chromeos/dbus/shill_client_unittest_base.h
+++ b/chromeos/dbus/shill_client_unittest_base.h
@@ -79,7 +79,6 @@ class ShillClientUnittestBase : public testing::Test {
                                     const base::Value* expected_value,
                                     const std::string& name,
                                     const base::Value& value);

[hashimoto, 2012/09/24 02:28:56]

nit: Please keep a blank line here.

[Greg Spencer (Chromium), 2012/09/24 21:50:54]

Done.

-
   // Expects the reader to be empty.
   static void ExpectNoArgument(dbus::MessageReader* reader);
 
@@ -105,10 +104,18 @@ class ShillClientUnittestBase : public testing::Test {
                                      const dbus::ObjectPath& result);
 
   // Checks the result and expects the call status to be SUCCESS.
+  static void ExpectObjectPathResultWithoutStatus(
+      const dbus::ObjectPath& expected_result,
+      const dbus::ObjectPath& result);
+
+  // Checks the result and expects the call status to be SUCCESS.
   static void ExpectDictionaryValueResult(
       const base::DictionaryValue* expected_result,
       DBusMethodCallStatus call_status,
       const base::DictionaryValue& result);
+  static void ExpectDictionaryValueResultWithoutStatus(

[hashimoto, 2012/09/24 02:28:56]

Please add a blank line and a method comment before this method.

[Greg Spencer (Chromium), 2012/09/24 21:50:54]

Done.

+      const base::DictionaryValue* expected_result,
+      const base::DictionaryValue& result);
 
   // A message loop to emulate asynchronous behavior.
   MessageLoop message_loop_;