chromeos/dbus/shill_device_client.h - Issue 10949030: This converts the Shill clients to allow propagation of shill errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_device_client.h

Issue 10949030: This converts the Shill clients to allow propagation of shill errors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix bad merge Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/dbus/shill_device_client.h

diff --git a/chromeos/dbus/shill_device_client.h b/chromeos/dbus/shill_device_client.h

index c4e808ce861b988b75b7c68eb8dae229f011a723..7ac7e20099714fabf2feff2a36d2b7a51adfc164 100644

--- a/chromeos/dbus/shill_device_client.h

+++ b/chromeos/dbus/shill_device_client.h

@@ -81,7 +81,8 @@ class CHROMEOS_EXPORT ShillDeviceClient {

virtual void SetProperty(const dbus::ObjectPath& device_path,

const std::string& name,

const base::Value& value,

- const VoidDBusMethodCallback& callback) = 0;

+ const base::Closure& callback,

+ const ErrorCallback& error_callback) = 0;

// Calls ClearProperty method.

// |callback| is called after the method call finishes.

« no previous file with comments | « chromeos/dbus/shill_client_unittest_base.cc ('k') | chromeos/dbus/shill_device_client.cc » ('j') | no next file with comments »