Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chromeos/dbus/shill_device_client.h

Issue 10949030: This converts the Shill clients to allow propagation of shill errors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Review changes Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_device_client.h
diff --git a/chromeos/dbus/shill_device_client.h b/chromeos/dbus/shill_device_client.h
index affe2c4a0687698ec6e695c6938fb17fc6879ad4..3240694ae620af9b2acd0b8448b62f53269c3590 100644
--- a/chromeos/dbus/shill_device_client.h
+++ b/chromeos/dbus/shill_device_client.h
@@ -78,7 +78,8 @@ class CHROMEOS_EXPORT ShillDeviceClient {
virtual void SetProperty(const dbus::ObjectPath& device_path,
const std::string& name,
const base::Value& value,
- const VoidDBusMethodCallback& callback) = 0;
+ const base::Closure& callback,
+ const ErrorCallback& error_callback) = 0;
// Calls ClearProperty method.
// |callback| is called after the method call finishes.
@@ -90,7 +91,7 @@ class CHROMEOS_EXPORT ShillDeviceClient {
// |callback| is called after the method call finishes.
virtual void AddIPConfig(const dbus::ObjectPath& device_path,
const std::string& method,
- const ObjectPathDBusMethodCallback& callback) = 0;
+ const ObjectPathCallback& callback) = 0;
// DEPRECATED DO NOT USE: Calls AddIPConfig method and blocks until the method
// call finishes.

Powered by Google App Engine
This is Rietveld 408576698