Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chromeos/dbus/mock_shill_profile_client.h

Issue 10949030: This converts the Shill clients to allow propagation of shill errors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/mock_shill_profile_client.h
diff --git a/chromeos/dbus/mock_shill_profile_client.h b/chromeos/dbus/mock_shill_profile_client.h
index bd0125dc041c02abee99994ed15c3f4dc3202fc3..fd8eaa3734d1d3750500b478b42dd78192cba886 100644
--- a/chromeos/dbus/mock_shill_profile_client.h
+++ b/chromeos/dbus/mock_shill_profile_client.h
@@ -17,19 +17,25 @@ class MockShillProfileClient : public ShillProfileClient {
MockShillProfileClient();
virtual ~MockShillProfileClient();
- MOCK_METHOD2(SetPropertyChangedHandler,
+ MOCK_METHOD2(AddPropertyChangedObserver,
void(const dbus::ObjectPath& profile_path,
- const PropertyChangedHandler& handler));
- MOCK_METHOD1(ResetPropertyChangedHandler,
- void(const dbus::ObjectPath& profile_path));
- MOCK_METHOD2(GetProperties, void(const dbus::ObjectPath& profile_path,
- const DictionaryValueCallback& callback));
- MOCK_METHOD3(GetEntry, void(const dbus::ObjectPath& profile_path,
- const std::string& entry_path,
- const DictionaryValueCallback& callback));
- MOCK_METHOD3(DeleteEntry, void(const dbus::ObjectPath& profile_path,
+ ShillClientHelper::PropertyChangedObserver* observer));
+ MOCK_METHOD2(RemovePropertyChangedObserver,
+ void(const dbus::ObjectPath& profile_path,
+ ShillClientHelper::PropertyChangedObserver* observer));
+ MOCK_METHOD3(GetProperties, void(
+ const dbus::ObjectPath& profile_path,
+ const DictionaryValueCallbackWithoutStatus& callback,
+ const ErrorCallback& error_callback));
+ MOCK_METHOD4(GetEntry, void(
+ const dbus::ObjectPath& profile_path,
+ const std::string& entry_path,
+ const DictionaryValueCallbackWithoutStatus& callback,
+ const ErrorCallback& error_callback));
+ MOCK_METHOD4(DeleteEntry, void(const dbus::ObjectPath& profile_path,
const std::string& entry_path,
- const VoidDBusMethodCallback& callback));
+ const base::Closure& callback,
+ const ErrorCallback& error_callback));
};
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698