This converts the Shill clients to allow propagation of shill errors

chromeos/dbus/shill_network_client.h

Index: chromeos/dbus/shill_network_client.h
diff --git a/chromeos/dbus/shill_network_client.h b/chromeos/dbus/shill_network_client.h
index 78e1f4c62da7e8367aa4b53e5c58709b6a02431c..22ed8211d0e380af0913ec2cddc96742516e5fa8 100644
--- a/chromeos/dbus/shill_network_client.h
+++ b/chromeos/dbus/shill_network_client.h
@@ -36,6 +36,7 @@ class CHROMEOS_EXPORT ShillNetworkClient {
  public:
   typedef ShillClientHelper::PropertyChangedHandler PropertyChangedHandler;
   typedef ShillClientHelper::DictionaryValueCallback DictionaryValueCallback;
+  typedef ShillClientHelper::PropertyChangedObserver PropertyChangedObserver;
 
   virtual ~ShillNetworkClient();
 
@@ -44,14 +45,13 @@ class CHROMEOS_EXPORT ShillNetworkClient {
   static ShillNetworkClient* Create(DBusClientImplementationType type,
                                        dbus::Bus* bus);
 
-  // Sets PropertyChanged signal handler.
-  virtual void SetPropertyChangedHandler(
+  virtual void AddPropertyChangedObserver(

[hashimoto, 2012/09/21 11:52:01]

Please add method comments.

[Greg Spencer (Chromium), 2012/09/21 22:03:47]

Done.

       const dbus::ObjectPath& network_path,
-      const PropertyChangedHandler& handler) = 0;
+      PropertyChangedObserver* observer) = 0;
 
-  // Resets PropertyChanged signal handler.
-  virtual void ResetPropertyChangedHandler(
-      const dbus::ObjectPath& network_path) = 0;
+  virtual void RemovePropertyChangedObserver(
+      const dbus::ObjectPath& network_path,
+      PropertyChangedObserver* observer) = 0;
 
   // Calls GetProperties method.
   // |callback| is called after the method call succeeds.