This converts the Shill clients to allow propagation of shill errors

chromeos/dbus/shill_ipconfig_client.h

Index: chromeos/dbus/shill_ipconfig_client.h
diff --git a/chromeos/dbus/shill_ipconfig_client.h b/chromeos/dbus/shill_ipconfig_client.h
index c87d829632b536d84ba52a8b89672d5f0bc28e03..98be48ac793494ae77b42179b72f7ea30ace29b9 100644
--- a/chromeos/dbus/shill_ipconfig_client.h
+++ b/chromeos/dbus/shill_ipconfig_client.h
@@ -36,6 +36,7 @@ class CHROMEOS_EXPORT ShillIPConfigClient {
  public:
   typedef ShillClientHelper::PropertyChangedHandler PropertyChangedHandler;
   typedef ShillClientHelper::DictionaryValueCallback DictionaryValueCallback;
+  typedef ShillClientHelper::PropertyChangedObserver PropertyChangedObserver;
   virtual ~ShillIPConfigClient();
 
   // Factory function, creates a new instance which is owned by the caller.
@@ -43,14 +44,13 @@ class CHROMEOS_EXPORT ShillIPConfigClient {
   static ShillIPConfigClient* Create(DBusClientImplementationType type,
                                         dbus::Bus* bus);
 
-  // Sets PropertyChanged signal handler.
-  virtual void SetPropertyChangedHandler(
+  virtual void AddPropertyChangedObserver(

[hashimoto, 2012/09/21 11:52:01]

Please add method comments.

[Greg Spencer (Chromium), 2012/09/21 22:03:47]

Done.

       const dbus::ObjectPath& ipconfig_path,
-      const PropertyChangedHandler& handler) = 0;
+      PropertyChangedObserver* observer) = 0;
 
-  // Resets PropertyChanged signal handler.
-  virtual void ResetPropertyChangedHandler(
-      const dbus::ObjectPath& ipconfig_path) = 0;
+  virtual void RemovePropertyChangedObserver(
+      const dbus::ObjectPath& ipconfig_path,
+      PropertyChangedObserver* observer) = 0;
 
   // Refreshes the active IP configuration after service property changes and
   // renews the DHCP lease, if any.