This converts the Shill clients to allow propagation of shill errors

chromeos/dbus/dbus_method_call_status.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_DBUS_METHOD_CALL_STATUS_H_
 #define CHROMEOS_DBUS_DBUS_METHOD_CALL_STATUS_H_
 
 #include "base/callback.h"
 
 namespace dbus {
@@ skipping 21 matching lines @@
 // A callback to handle responses of methods returning a string value.
 typedef base::Callback<void(
     DBusMethodCallStatus call_status,
     const std::string& result)> StringDBusMethodCallback;
 
 // A callback to handle responses of methods returning a ObjectPath value.
 typedef base::Callback<void(
     DBusMethodCallStatus call_status,
     const dbus::ObjectPath& result)> ObjectPathDBusMethodCallback;
 
+// A callback to handle responses of methods returning a ObjectPath value that
+// doens't get call status.
+typedef base::Callback<void(
+    const dbus::ObjectPath& result)> ObjectPathCallbackWithoutStatus;

[hashimoto, 2012/09/24 02:28:56]

Just 'ObjectPathCallback'?
ShillClientHelper::DictionaryValueCallbackWithoutStatus was named
'-WithoutStatus' because 'DictionaryValueCallback' was already there.
If you place this callback here, I think you don't have to add 'WithoutStatus'.

[Greg Spencer (Chromium), 2012/09/24 21:50:54]

OK, or should I rename ObjectPathDBusMethodCallback to just be
ObjectPathCallback?  Or should the new one be called
ObjectPathDBusMethodCallbackWithoutStatus?

I think I'll do the first one, since that results in shorter names all around,
and I don't think that the "DBusMethod" part of the name adds anything.

[hashimoto, 2012/09/25 08:08:19]

I think we should keep the old one's name unchanged because its first argument
is DBusMethodCallStatus.

I also think 'ObjectPathCallback' is a very generic name and it should be a name
of a simple type like base::Callback<void(const dbus::ObjectPath&)>.

[Greg Spencer (Chromium), 2012/09/25 18:40:08]

OK, I kept the original one and renamed the new one to be ObjectPathCallback.

+
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_DBUS_METHOD_CALL_STATUS_H_