Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: chromeos/dbus/shill_device_client.h

Issue 10949030: This converts the Shill clients to allow propagation of shill errors (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix bad merge Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/dbus/shill_client_unittest_base.cc ('k') | chromeos/dbus/shill_device_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_
6 #define CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_ 6 #define CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 // Calls ProposeScan method. 74 // Calls ProposeScan method.
75 // |callback| is called after the method call finishes. 75 // |callback| is called after the method call finishes.
76 virtual void ProposeScan(const dbus::ObjectPath& device_path, 76 virtual void ProposeScan(const dbus::ObjectPath& device_path,
77 const VoidDBusMethodCallback& callback) = 0; 77 const VoidDBusMethodCallback& callback) = 0;
78 78
79 // Calls SetProperty method. 79 // Calls SetProperty method.
80 // |callback| is called after the method call finishes. 80 // |callback| is called after the method call finishes.
81 virtual void SetProperty(const dbus::ObjectPath& device_path, 81 virtual void SetProperty(const dbus::ObjectPath& device_path,
82 const std::string& name, 82 const std::string& name,
83 const base::Value& value, 83 const base::Value& value,
84 const VoidDBusMethodCallback& callback) = 0; 84 const base::Closure& callback,
85 const ErrorCallback& error_callback) = 0;
85 86
86 // Calls ClearProperty method. 87 // Calls ClearProperty method.
87 // |callback| is called after the method call finishes. 88 // |callback| is called after the method call finishes.
88 virtual void ClearProperty(const dbus::ObjectPath& device_path, 89 virtual void ClearProperty(const dbus::ObjectPath& device_path,
89 const std::string& name, 90 const std::string& name,
90 const VoidDBusMethodCallback& callback) = 0; 91 const VoidDBusMethodCallback& callback) = 0;
91 92
92 // Calls AddIPConfig method. 93 // Calls AddIPConfig method.
93 // |callback| is called after the method call finishes. 94 // |callback| is called after the method call finishes.
94 virtual void AddIPConfig(const dbus::ObjectPath& device_path, 95 virtual void AddIPConfig(const dbus::ObjectPath& device_path,
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 // Create() should be used instead. 155 // Create() should be used instead.
155 ShillDeviceClient(); 156 ShillDeviceClient();
156 157
157 private: 158 private:
158 DISALLOW_COPY_AND_ASSIGN(ShillDeviceClient); 159 DISALLOW_COPY_AND_ASSIGN(ShillDeviceClient);
159 }; 160 };
160 161
161 } // namespace chromeos 162 } // namespace chromeos
162 163
163 #endif // CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_ 164 #endif // CHROMEOS_DBUS_SHILL_DEVICE_CLIENT_H_
OLDNEW
« no previous file with comments | « chromeos/dbus/shill_client_unittest_base.cc ('k') | chromeos/dbus/shill_device_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698