Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 10949023: Add switch to provide app window size on startup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index 662227e1478ad2ea80e577f7e8b6cded83f6d452..1233ed1aa971e0942c21b692b7a28dc9afd1daa6 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -74,6 +74,9 @@ const long int kReleaseNotesTargetRelease = 19;
const char kGetStartedURLPattern[] =
"http://gweb-gettingstartedguide.appspot.com/";
+// Getting started guide application window size.
+const char kGSGAppWindowSize[] = "820,550";
sky 2012/09/19 17:20:14 Shouldn't this be specified externally so we can t
Nikita (slow) 2012/09/19 17:46:42 Min said that we do want to start with same size a
+
// Parameter to be added to GetStarted URL that contains board.
const char kGetStartedBoardParam[] = "board";
@@ -810,9 +813,8 @@ void ExistingUserController::InitializeStartUrls() const {
if (!guide_url.empty()) {
CommandLine::ForCurrentProcess()->AppendSwitchASCII(switches::kApp,
guide_url);
- // NTP would open in the background, app window with GSG would be focused
- // so that user won't have an empty desktop after GSG is closed.
- CommandLine::ForCurrentProcess()->AppendArg(chrome::kChromeUINewTabURL);
+ CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+ switches::kAppWindowSize, kGSGAppWindowSize);
} else {
// We should not be adding any start URLs if guide
// is defined as it launches as a standalone app window.

Powered by Google App Engine
This is Rietveld 408576698