Fix toolbar keyboard accessibility on Views (alternative impl).

ui/views/accessible_pane_view.cc

Index: ui/views/accessible_pane_view.cc
diff --git a/ui/views/accessible_pane_view.cc b/ui/views/accessible_pane_view.cc
index ab12435bc1414b234c6d4b3236224d7641dcb9d4..51b4cb5faf6eb731d7b1720338d84ae133cc74b8 100644
--- a/ui/views/accessible_pane_view.cc
+++ b/ui/views/accessible_pane_view.cc
@@ -12,6 +12,28 @@
 
 namespace views {
 
+class AccessiblePaneViewFocusSearch : public FocusSearch {

[sky, 2012/09/18 21:46:06]

Document why this is needed.

[dmazzoni, 2012/09/19 00:23:40]

Done.

+ public:
+  explicit AccessiblePaneViewFocusSearch(AccessiblePaneView* pane_view)
+      : FocusSearch(pane_view, true, true),
+        accessible_pane_view_(pane_view) {}
+
+ protected:
+  virtual View* GetParent(View* v) OVERRIDE {
+    return accessible_pane_view_->ContainsForFocusSearch(root(), v) ?
+        accessible_pane_view_->GetParentForFocusSearch(v) : NULL;
+  }
+
+  // Returns true if |v| is contained within the hierarchy rooted at |root|.
+  // Subclasses can override this if they need custom focus search behavior.
+  virtual bool Contains(View* root, const View* v) OVERRIDE {
+    return accessible_pane_view_->ContainsForFocusSearch(root, v);
+  }
+
+ private:
+  AccessiblePaneView* accessible_pane_view_;
+};

[sky, 2012/09/18 21:46:06]

DISALLOW_...

[dmazzoni, 2012/09/19 00:23:40]

Done.

+
 AccessiblePaneView::AccessiblePaneView()
     : pane_has_focus_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
@@ -21,7 +43,7 @@ AccessiblePaneView::AccessiblePaneView()
       escape_key_(ui::VKEY_ESCAPE, ui::EF_NONE),
       left_key_(ui::VKEY_LEFT, ui::EF_NONE),
       right_key_(ui::VKEY_RIGHT, ui::EF_NONE) {
-  focus_search_.reset(new views::FocusSearch(this, true, true));
+  focus_search_.reset(new AccessiblePaneViewFocusSearch(this));
 }
 
 AccessiblePaneView::~AccessiblePaneView() {
@@ -42,7 +64,7 @@ bool AccessiblePaneView::SetPaneFocus(views::View* initial_focus) {
   // Use the provided initial focus if it's visible and enabled, otherwise
   // use the first focusable child.
   if (!initial_focus ||
-      !Contains(initial_focus) ||
+      !ContainsForFocusSearch(this, initial_focus) ||
       !initial_focus->visible() ||
       !initial_focus->enabled()) {
     initial_focus = GetFirstFocusableChild();
@@ -80,6 +102,14 @@ views::View* AccessiblePaneView::GetDefaultFocusableChild() {
   return NULL;
 }
 
+View* AccessiblePaneView::GetParentForFocusSearch(View* v) {
+  return v->parent();
+}
+
+bool AccessiblePaneView::ContainsForFocusSearch(View* root, const View* v) {
+  return root->Contains(v);
+}
+
 void AccessiblePaneView::RemovePaneFocus() {
   focus_manager_->RemoveFocusChangeListener(this);
   pane_has_focus_ = false;
@@ -121,7 +151,7 @@ bool AccessiblePaneView::AcceleratorPressed(
     const ui::Accelerator& accelerator) {
 
   const views::View* focused_view = focus_manager_->GetFocusedView();
-  if (!Contains(focused_view))
+  if (!ContainsForFocusSearch(this, focused_view))
     return false;
 
   switch (accelerator.key_code()) {
@@ -176,7 +206,7 @@ void AccessiblePaneView::OnDidChangeFocus(views::View* focused_before,
   views::FocusManager::FocusChangeReason reason =
       focus_manager_->focus_change_reason();
 
-  if (!Contains(focused_now) ||
+  if (!ContainsForFocusSearch(this, focused_now) ||
       reason == views::FocusManager::kReasonDirectFocusChange) {
     // We should remove pane focus (i.e. make most of the controls
     // not focusable again) because the focus has left the pane,