Make quota requests from background pages not crash

chrome/browser/chrome_quota_permission_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_quota_permission_context.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/utf_string_conversions.h"
@@ skipping 120 matching lines @@
       tab_util::GetWebContentsByID(render_process_id, render_view_id);
   if (!web_contents) {
     // The tab may have gone away or the request may not be from a tab.
     LOG(WARNING) << "Attempt to request quota tabless renderer: "
                  << render_process_id << "," << render_view_id;
     DispatchCallbackOnIOThread(callback, QUOTA_PERMISSION_RESPONSE_CANCELLED);
     return;
   }
 
   TabContents* tab_contents = TabContents::FromWebContents(web_contents);
-  InfoBarTabHelper* infobar_helper = tab_contents->infobar_tab_helper();
+  InfoBarTabHelper* infobar_helper =
+          tab_contents ? tab_contents->infobar_tab_helper() : NULL;

[kinuko, 2012/09/18 05:03:35]

nit: indent

[tzik, 2012/09/19 12:08:54]

Thanks. I fixed it and my .emacs.

   if (!infobar_helper) {
     // The tab has no infobar helper.
     LOG(WARNING) << "Attempt to request quota from a background page: "
                  << render_process_id << "," << render_view_id;
     DispatchCallbackOnIOThread(callback, QUOTA_PERMISSION_RESPONSE_CANCELLED);
     return;
   }
   infobar_helper->AddInfoBar(new RequestQuotaInfoBarDelegate(
       infobar_helper, this, origin_url, requested_quota,
       tab_contents->profile()->GetPrefs()->GetString(prefs::kAcceptLanguages),
@@ skipping 10 matching lines @@
         BrowserThread::IO, FROM_HERE,
         base::Bind(&ChromeQuotaPermissionContext::DispatchCallbackOnIOThread,
                    this, callback, response));
     return;
   }
 
   callback.Run(response);
 }
 
 ChromeQuotaPermissionContext::~ChromeQuotaPermissionContext() {}