Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporated Peter's comments and feedback. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/elements/elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compile_time_constants.dart
diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart
index 8e67ebc37cf07849c6d241007274a212c0ef4bda..75ea2cb2696dc401e11364f672c8fffa502c798c 100644
--- a/lib/compiler/implementation/compile_time_constants.dart
+++ b/lib/compiler/implementation/compile_time_constants.dart
@@ -767,16 +767,17 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
if (enclosingClass != compiler.objectClass) {
assert(superClass !== null);
assert(superClass.resolutionState == STATE_DONE);
+
+ Selector selector =
+ new Selector.callDefaultConstructor(enclosingClass.getLibrary());
+
FunctionElement targetConstructor =
- superClass.lookupConstructor(superClass.name);
+ superClass.lookupConstructor(selector);
if (targetConstructor === null) {
compiler.internalError("no default constructor available",
node: functionNode);
}
- Selector selector = new Selector.call(superClass.name,
- enclosingClass.getLibrary(),
- 0);
evaluateSuperOrRedirectSend(functionNode,
selector,
const EmptyLink<Node>(),
« no previous file with comments | « no previous file | lib/compiler/implementation/elements/elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698