Don't return unsupported scales frrom GetScaleFactorFromScale()

ui/base/layout_unittest.cc

Index: ui/base/layout_unittest.cc
diff --git a/ui/base/layout_unittest.cc b/ui/base/layout_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3bb8fd0e75d515a5fb8a475d1ee6353117cafd1b
--- /dev/null
+++ b/ui/base/layout_unittest.cc
@@ -0,0 +1,79 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "ui/base/layout.h"

[oshima, 2012/09/20 18:10:55]

nit: swap include order. (test file should have the header of the code it is
testing first. check out other *test.cc)

[Xianzhu, 2012/09/20 18:51:33]

Done.

+
+namespace ui {
+
+TEST(LayoutTest, GetScaleFactorScale) {
+  EXPECT_FLOAT_EQ(1, GetScaleFactorScale(SCALE_FACTOR_100P));
+  EXPECT_FLOAT_EQ(1.4, GetScaleFactorScale(SCALE_FACTOR_140P));
+  EXPECT_FLOAT_EQ(1.8, GetScaleFactorScale(SCALE_FACTOR_180P));
+  EXPECT_FLOAT_EQ(2, GetScaleFactorScale(SCALE_FACTOR_200P));
+}
+
+TEST(LayoutTest, GetScaleFactorFromScaleNoneSupported) {
+  std::vector<ScaleFactor> original_supported_factors =
+      GetSupportedScaleFactors();
+
+  std::vector<ScaleFactor> supported_factors;
+  test::SetSupportedScaleFactors(supported_factors);
+  for (float scale = 0.1; scale < 3; scale += 0.1)
+    EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(scale));
+
+  test::SetSupportedScaleFactors(original_supported_factors);
+}
+
+TEST(LayoutTest, GetScaleFactorFromScalePartlySupported) {
+  std::vector<ScaleFactor> original_supported_factors =
+      GetSupportedScaleFactors();
+
+  std::vector<ScaleFactor> supported_factors;
+  supported_factors.push_back(SCALE_FACTOR_100P);
+  supported_factors.push_back(SCALE_FACTOR_180P);
+  test::SetSupportedScaleFactors(supported_factors);
+  EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(0.1));
+  EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(0.9));
+  EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(1));
+  EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(1.39));
+  EXPECT_EQ(SCALE_FACTOR_180P, GetScaleFactorFromScale(1.41));
+  EXPECT_EQ(SCALE_FACTOR_180P, GetScaleFactorFromScale(1.8));
+  EXPECT_EQ(SCALE_FACTOR_180P, GetScaleFactorFromScale(2));
+  EXPECT_EQ(SCALE_FACTOR_180P, GetScaleFactorFromScale(999));
+
+  test::SetSupportedScaleFactors(original_supported_factors);
+}
+
+TEST(LayoutTest, GetScaleFactorFromScaleAllSupported) {
+  std::vector<ScaleFactor> original_supported_factors =
+      GetSupportedScaleFactors();
+
+  std::vector<ScaleFactor> supported_factors;
+  supported_factors.push_back(SCALE_FACTOR_100P);
+  supported_factors.push_back(SCALE_FACTOR_140P);
+  supported_factors.push_back(SCALE_FACTOR_180P);
+  supported_factors.push_back(SCALE_FACTOR_200P);
+  test::SetSupportedScaleFactors(supported_factors);
+  EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(0.1));
+  EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(0.9));
+  EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(1));
+  EXPECT_EQ(SCALE_FACTOR_100P, GetScaleFactorFromScale(1.19));
+  EXPECT_EQ(SCALE_FACTOR_140P, GetScaleFactorFromScale(1.21));
+  EXPECT_EQ(SCALE_FACTOR_140P, GetScaleFactorFromScale(1.3));
+  EXPECT_EQ(SCALE_FACTOR_140P, GetScaleFactorFromScale(1.4));
+  EXPECT_EQ(SCALE_FACTOR_140P, GetScaleFactorFromScale(1.59));
+  EXPECT_EQ(SCALE_FACTOR_180P, GetScaleFactorFromScale(1.61));
+  EXPECT_EQ(SCALE_FACTOR_180P, GetScaleFactorFromScale(1.7));
+  EXPECT_EQ(SCALE_FACTOR_180P, GetScaleFactorFromScale(1.89));
+  EXPECT_EQ(SCALE_FACTOR_200P, GetScaleFactorFromScale(1.91));
+  EXPECT_EQ(SCALE_FACTOR_200P, GetScaleFactorFromScale(2));
+  EXPECT_EQ(SCALE_FACTOR_200P, GetScaleFactorFromScale(2.1));
+  EXPECT_EQ(SCALE_FACTOR_200P, GetScaleFactorFromScale(999));
+
+  test::SetSupportedScaleFactors(original_supported_factors);
+}
+
+}  // namespace ui