chrome/test/data/chromeos/network_settings/normalize.json - Issue 10944009: Implementation of ONC signature, validator and normalizer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/chromeos/network_settings/normalize.json

Issue 10944009: Implementation of ONC signature, validator and normalizer. (Closed) Base URL: http://git.chromium.org/chromium/src.git@gperffix

Patch Set: Completed validator for complete ONC. Integrated into OncNetworkParser. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {
	Mattias Nissler (ping if slow) 2012/11/02 10:10:00 "normalize.json" is a curious name. If this is the "normalize.json" is a curious name. If this is the input to the normalizer, it should probably be "to_be_normalized.json", if the is the expected result, it should be "normalized.json". pneubeck (no reviews) 2012/11/05 12:04:48 It contains both. Renamed to "settings_with_normal Show quoted text On 2012/11/02 10:10:00, Mattias Nissler wrote: > "normalize.json" is a curious name. If this is the input to the normalizer, it > should probably be "to_be_normalized.json", if the is the expected result, it > should be "normalized.json". It contains both. Renamed to "settings_with_normalization.json". Also renamed "invalid.json" to "invalid_settings_with_repairs.json"
	2 "ethernet-and-vpn": {

	3 "Recommended": [],

	4 "GUID": "guid",

	5 "Type": "Ethernet",

	6 "Name": "name",

	7 "Ethernet": {

	8 "Authentication": "None"

	9 },

	10 "VPN": {

	11 "Type": "L2TP-IPsec",

	12 "Host": "some.host.org",

	13 "IPsec": {

	14 "AuthenticationType": "PSK",

	15 "IKEVersion": 1,

	16 "PSK": "some_preshared_key",

	17 "SaveCredentials": true

	18 },

	19 "L2TP": {

	20 "Username": "some username",

	21 "Password": "some password"

	22 }

	23 }

	24 },

	25 "ethernet-and-vpn-normalized": {

	26 "GUID": "guid",

	27 "Type": "Ethernet",

	28 "Name": "name",

	29 "Ethernet": {

	30 "Authentication": "None"

	31 }

	32 },

	33 }

OLD	NEW