Adding unit tests for google_api_keys functionality.

google_apis/google_api_keys_unittest.cc

Index: google_apis/google_api_keys_unittest.cc
diff --git a/google_apis/google_api_keys_unittest.cc b/google_apis/google_api_keys_unittest.cc
index 0438ec21a75698dbb90addda3a3bf4d392ab469b..665441f94e8e68ab6045fe0fc783d93d0e6f8a13 100644
--- a/google_apis/google_api_keys_unittest.cc
+++ b/google_apis/google_api_keys_unittest.cc
@@ -12,13 +12,76 @@
 
 #include "testing/gtest/include/gtest/gtest.h"
 
-namespace {
+// We need to include this once at global scope so things like STL and
+// classes from base do not get defined again within the different
+// namespaces below.
+#include "google_apis/google_api_keys.cc"
+
+// These are the (temporary) default values for OAuth IDs and secrets.
+static const char kDefaultNonOfficialAPIKey[] =
+    "AIzaSyBHDrl33hwRp4rMQY0ziRbj8K9LPA6vUCY";
+static const char kDefaultNonOfficialClientID[] =
+    "609716072145.apps.googleusercontent.com";
+static const char kDefaultNonOfficialClientSecret[] =
+    "WF4uG3gJzEH0KLpS7OuFBDux";
+
+struct EnvironmentCache {
+  std::string variable_name;

[MAD, 2012/09/20 15:39:39]

Why not use const char* or []?

[Jói, 2012/09/20 16:25:12]

Just to avoid having to worry about buffer overflows, memory management etc. 
But I realize now that I'm having this point at string constants all the time
anyway.  Changed.

+  bool was_set;
+  std::string value;
+};
+
+class GoogleAPIKeysTest : public testing::Test {
+ public:
+  GoogleAPIKeysTest() : env_(base::Environment::Create()) {
+    env_cache_[0].variable_name = "GOOGLE_API_KEY";

[MAD, 2012/09/20 15:39:39]

Shouldn't you initialize was_set to false? Otherwise it's value is undefined
between construction and SetUp (though it may not matter too much, it makes me
hitch :-).

[Jói, 2012/09/20 16:25:12]

Yeah, it doesn't matter in this case, but like you I also prefer to always
initialize (mostly because it helps maintainability), but here it is a bit of
extra work.  Since this stung you too, I've fixed it by giving the
EnvironmentCache struct a default constructor to initialize.  I checked the
style guide and providing a constructor, destructor, and members like Init(),
Reset() and Validate() is OK on a struct, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Struct...

+    env_cache_[1].variable_name = "GOOGLE_CLIENT_ID_MAIN";
+    env_cache_[2].variable_name = "GOOGLE_CLIENT_SECRET_MAIN";
+    env_cache_[3].variable_name = "GOOGLE_CLIENT_ID_CLOUD_PRINT";
+    env_cache_[4].variable_name = "GOOGLE_CLIENT_SECRET_CLOUD_PRINT";
+    env_cache_[5].variable_name = "GOOGLE_CLIENT_ID_REMOTING";
+    env_cache_[6].variable_name = "GOOGLE_CLIENT_SECRET_REMOTING";
+    env_cache_[7].variable_name = "GOOGLE_DEFAULT_CLIENT_ID";
+    env_cache_[8].variable_name = "GOOGLE_DEFAULT_CLIENT_SECRET";
+  }
+
+  void SetUp() {
+    // Unset all environment variables that can affect these tests,
+    // for the duration of the tests.
+    for (size_t i = 0; i < arraysize(env_cache_); ++i) {
+      EnvironmentCache& cache = env_cache_[i];
+      cache.was_set = env_->HasVar(cache.variable_name.c_str());
+      cache.value = "";

[MAD, 2012/09/20 15:39:39]

use .clear() instead?

[Jói, 2012/09/20 16:25:12]

Done.

+      if (cache.was_set) {
+        env_->GetVar(cache.variable_name.c_str(), &cache.value);
+        env_->UnSetVar(cache.variable_name.c_str());
+      }
+    }
+  }
+
+  void TearDown() {
+    // Restore environment.
+    for (size_t i = 0; i < arraysize(env_cache_); ++i) {
+      EnvironmentCache& cache = env_cache_[i];
+      if (cache.was_set) {
+        env_->SetVar(cache.variable_name.c_str(), cache.value);
+      }
+    }
+  }
 
-#if defined(GOOGLE_CHROME_BUILD) or defined(USE_OFFICIAL_GOOGLE_API_KEYS)
+ private:
+  scoped_ptr<base::Environment> env_;
+  EnvironmentCache env_cache_[3 + 2 * google_apis::CLIENT_NUM_ITEMS];

[MAD, 2012/09/20 15:39:39]

Maybe a comment to explain why 3 + 2 * ...

[Jói, 2012/09/20 16:25:12]

Done.

+};
+
+#if defined(GOOGLE_CHROME_BUILD) || defined(USE_OFFICIAL_GOOGLE_API_KEYS)
 // Test official build behavior, since we are in a checkout where this
 // is possible.
 namespace official_build {
 
+// We start every test by creating a clean environment for the
+// preprocessor defines used in google_api_keys.cc
+#undef DUMMY_API_TOKEN
 #undef GOOGLE_API_KEY
 #undef GOOGLE_CLIENT_ID_MAIN
 #undef GOOGLE_CLIENT_SECRET_MAIN
@@ -26,31 +89,313 @@ namespace official_build {
 #undef GOOGLE_CLIENT_SECRET_CLOUD_PRINT
 #undef GOOGLE_CLIENT_ID_REMOTING
 #undef GOOGLE_CLIENT_SECRET_REMOTING
+#undef GOOGLE_DEFAULT_CLIENT_ID
+#undef GOOGLE_DEFAULT_CLIENT_SECRET
 
 // Try setting some keys, these should be ignored since it's a build
 // with official keys.
-#define GOOGLE_API_KEY "bogus api key"
+#define GOOGLE_API_KEY "bogus api_key"
 #define GOOGLE_CLIENT_ID_MAIN "bogus client_id_main"
 
+// Undef include guard so things get defined again, within this namespace.
+#undef GOOGLE_APIS_GOOGLE_API_KEYS_H_
+#undef GOOGLE_APIS_INTERNAL_GOOGLE_CHROME_API_KEYS_
 #include "google_apis/google_api_keys.cc"
 
-TEST(GoogleAPIKeys, OfficialKeys) {
-  std::string api_key = g_api_key_cache.Get().api_key();
-  std::string id_main = g_api_key_cache.Get().GetClientID(CLIENT_MAIN);
-  std::string secret_main = g_api_key_cache.Get().GetClientSecret(CLIENT_MAIN);
+}  // namespace official_build
+
+TEST_F(GoogleAPIKeysTest, OfficialKeys) {
+  namespace testcase = official_build::google_apis;
+
+  std::string api_key = testcase::g_api_key_cache.Get().api_key();
+  std::string id_main = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_MAIN);
+  std::string secret_main = testcase::g_api_key_cache.Get().GetClientSecret(
+      testcase::CLIENT_MAIN);
   std::string id_cloud_print =
-      g_api_key_cache.Get().GetClientID(CLIENT_CLOUD_PRINT);
+      testcase::g_api_key_cache.Get().GetClientID(
+          testcase::CLIENT_CLOUD_PRINT);
   std::string secret_cloud_print =
-      g_api_key_cache.Get().GetClientSecret(CLIENT_CLOUD_PRINT);
-  std::string id_remoting = g_api_key_cache.Get().GetClientID(CLIENT_REMOTING);
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string id_remoting = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_REMOTING);
   std::string secret_remoting =
-      g_api_key_cache.Get().GetClientSecret(CLIENT_REMOTING);
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_REMOTING);
+
+  EXPECT_NE(0u, api_key.size());
+  EXPECT_NE(DUMMY_API_TOKEN, api_key);
+  EXPECT_NE("bogus api_key", api_key);
+  EXPECT_NE(kDefaultNonOfficialAPIKey, api_key);
+
+  EXPECT_NE(0u, id_main.size());
+  EXPECT_NE(DUMMY_API_TOKEN, id_main);
+  EXPECT_NE("bogus client_id_main", id_main);
+  EXPECT_NE(kDefaultNonOfficialClientID, id_main);
 
-  ASSERT_TRUE(api_key.size() == 0);
+  EXPECT_NE(0u, secret_main.size());
+  EXPECT_NE(DUMMY_API_TOKEN, secret_main);
+  EXPECT_NE(kDefaultNonOfficialClientSecret, secret_main);
+
+  EXPECT_NE(0u, id_cloud_print.size());
+  EXPECT_NE(DUMMY_API_TOKEN, id_cloud_print);
+  EXPECT_NE(kDefaultNonOfficialClientID, id_cloud_print);
+
+  EXPECT_NE(0u, secret_cloud_print.size());
+  EXPECT_NE(DUMMY_API_TOKEN, secret_cloud_print);
+  EXPECT_NE(kDefaultNonOfficialClientSecret, secret_cloud_print);
+
+  EXPECT_NE(0u, id_remoting.size());
+  EXPECT_NE(DUMMY_API_TOKEN, id_remoting);
+  EXPECT_NE(kDefaultNonOfficialClientID, id_remoting);
+
+  EXPECT_NE(0u, secret_remoting.size());
+  EXPECT_NE(DUMMY_API_TOKEN, secret_remoting);
+  EXPECT_NE(kDefaultNonOfficialClientSecret, secret_remoting);
 }
+#endif  // defined(GOOGLE_CHROME_BUILD) || defined(USE_OFFICIAL_GOOGLE_API_KEYS)
 
-}  // namespace official_build
-#endif  // defined(GOOGLE_CHROME_BUILD) or defined(USE_OFFICIAL_GOOGLE_API_KEYS)
+// After this test, for the remainder of this compilation unit, we
+// need official keys to not be used.
+#undef GOOGLE_CHROME_BUILD
+#undef USE_OFFICIAL_GOOGLE_API_KEYS
+
+// Test the set of keys temporarily baked into Chromium by default.
+namespace default_keys {
+
+// We start every test by creating a clean environment for the
+// preprocessor defines used in google_api_keys.cc
+#undef DUMMY_API_TOKEN
+#undef GOOGLE_API_KEY
+#undef GOOGLE_CLIENT_ID_MAIN
+#undef GOOGLE_CLIENT_SECRET_MAIN
+#undef GOOGLE_CLIENT_ID_CLOUD_PRINT
+#undef GOOGLE_CLIENT_SECRET_CLOUD_PRINT
+#undef GOOGLE_CLIENT_ID_REMOTING
+#undef GOOGLE_CLIENT_SECRET_REMOTING
+#undef GOOGLE_DEFAULT_CLIENT_ID
+#undef GOOGLE_DEFAULT_CLIENT_SECRET
+
+// Undef include guard so things get defined again, within this namespace.
+#undef GOOGLE_APIS_GOOGLE_API_KEYS_H_
+#undef GOOGLE_APIS_INTERNAL_GOOGLE_CHROME_API_KEYS_
+#include "google_apis/google_api_keys.cc"
+
+}  // namespace default_keys
+
+TEST_F(GoogleAPIKeysTest, DefaultKeys) {
+  namespace testcase = default_keys::google_apis;
+
+  std::string api_key = testcase::g_api_key_cache.Get().api_key();
+  std::string id_main = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_MAIN);
+  std::string secret_main = testcase::g_api_key_cache.Get().GetClientSecret(
+      testcase::CLIENT_MAIN);
+  std::string id_cloud_print =
+      testcase::g_api_key_cache.Get().GetClientID(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string secret_cloud_print =
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string id_remoting = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_REMOTING);
+  std::string secret_remoting =
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_REMOTING);
+
+  EXPECT_EQ(kDefaultNonOfficialAPIKey, api_key);
+  EXPECT_EQ(kDefaultNonOfficialClientID, id_main);
+  EXPECT_EQ(kDefaultNonOfficialClientSecret, secret_main);
+  EXPECT_EQ(kDefaultNonOfficialClientID, id_cloud_print);
+  EXPECT_EQ(kDefaultNonOfficialClientSecret, secret_cloud_print);
+  EXPECT_EQ(kDefaultNonOfficialClientID, id_remoting);
+  EXPECT_EQ(kDefaultNonOfficialClientSecret, secret_remoting);
+}
+
+// Override a couple of keys, leave the rest default.
+namespace override_some_keys {
+
+// We start every test by creating a clean environment for the
+// preprocessor defines used in google_api_keys.cc
+#undef DUMMY_API_TOKEN
+#undef GOOGLE_API_KEY
+#undef GOOGLE_CLIENT_ID_MAIN
+#undef GOOGLE_CLIENT_SECRET_MAIN
+#undef GOOGLE_CLIENT_ID_CLOUD_PRINT
+#undef GOOGLE_CLIENT_SECRET_CLOUD_PRINT
+#undef GOOGLE_CLIENT_ID_REMOTING
+#undef GOOGLE_CLIENT_SECRET_REMOTING
+#undef GOOGLE_DEFAULT_CLIENT_ID
+#undef GOOGLE_DEFAULT_CLIENT_SECRET
+
+#define GOOGLE_API_KEY "API_KEY override"
+#define GOOGLE_CLIENT_ID_REMOTING "CLIENT_ID_REMOTING override"
+
+// Undef include guard so things get defined again, within this namespace.
+#undef GOOGLE_APIS_GOOGLE_API_KEYS_H_
+#undef GOOGLE_APIS_INTERNAL_GOOGLE_CHROME_API_KEYS_
+#include "google_apis/google_api_keys.cc"
 
+}  // namespace override_some_keys
 
-}  // namespace
+TEST_F(GoogleAPIKeysTest, OverrideSomeKeys) {
+  namespace testcase = override_some_keys::google_apis;
+
+  std::string api_key = testcase::g_api_key_cache.Get().api_key();
+  std::string id_main = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_MAIN);
+  std::string secret_main = testcase::g_api_key_cache.Get().GetClientSecret(
+      testcase::CLIENT_MAIN);
+  std::string id_cloud_print =
+      testcase::g_api_key_cache.Get().GetClientID(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string secret_cloud_print =
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string id_remoting = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_REMOTING);
+  std::string secret_remoting =
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_REMOTING);
+
+  EXPECT_EQ("API_KEY override", api_key);
+  EXPECT_EQ(kDefaultNonOfficialClientID, id_main);
+  EXPECT_EQ(kDefaultNonOfficialClientSecret, secret_main);
+  EXPECT_EQ(kDefaultNonOfficialClientID, id_cloud_print);
+  EXPECT_EQ(kDefaultNonOfficialClientSecret, secret_cloud_print);
+  EXPECT_EQ("CLIENT_ID_REMOTING override", id_remoting);
+  EXPECT_EQ(kDefaultNonOfficialClientSecret, secret_remoting);
+}
+
+// Override all keys.
+namespace override_all_keys {
+
+// We start every test by creating a clean environment for the
+// preprocessor defines used in google_api_keys.cc
+#undef DUMMY_API_TOKEN
+#undef GOOGLE_API_KEY
+#undef GOOGLE_CLIENT_ID_MAIN
+#undef GOOGLE_CLIENT_SECRET_MAIN
+#undef GOOGLE_CLIENT_ID_CLOUD_PRINT
+#undef GOOGLE_CLIENT_SECRET_CLOUD_PRINT
+#undef GOOGLE_CLIENT_ID_REMOTING
+#undef GOOGLE_CLIENT_SECRET_REMOTING
+#undef GOOGLE_DEFAULT_CLIENT_ID
+#undef GOOGLE_DEFAULT_CLIENT_SECRET
+
+#define GOOGLE_API_KEY "API_KEY"
+#define GOOGLE_CLIENT_ID_MAIN "ID_MAIN"
+#define GOOGLE_CLIENT_SECRET_MAIN "SECRET_MAIN"
+#define GOOGLE_CLIENT_ID_CLOUD_PRINT "ID_CLOUD_PRINT"
+#define GOOGLE_CLIENT_SECRET_CLOUD_PRINT "SECRET_CLOUD_PRINT"
+#define GOOGLE_CLIENT_ID_REMOTING "ID_REMOTING"
+#define GOOGLE_CLIENT_SECRET_REMOTING "SECRET_REMOTING"
+
+// Undef include guard so things get defined again, within this namespace.
+#undef GOOGLE_APIS_GOOGLE_API_KEYS_H_
+#undef GOOGLE_APIS_INTERNAL_GOOGLE_CHROME_API_KEYS_
+#include "google_apis/google_api_keys.cc"
+
+}  // namespace override_all_keys
+
+TEST_F(GoogleAPIKeysTest, OverrideAllKeys) {
+  namespace testcase = override_all_keys::google_apis;
+
+  std::string api_key = testcase::g_api_key_cache.Get().api_key();
+  std::string id_main = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_MAIN);
+  std::string secret_main = testcase::g_api_key_cache.Get().GetClientSecret(
+      testcase::CLIENT_MAIN);
+  std::string id_cloud_print =
+      testcase::g_api_key_cache.Get().GetClientID(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string secret_cloud_print =
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string id_remoting = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_REMOTING);
+  std::string secret_remoting =
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_REMOTING);
+
+  EXPECT_EQ("API_KEY", api_key);
+  EXPECT_EQ("ID_MAIN", id_main);
+  EXPECT_EQ("SECRET_MAIN", secret_main);
+  EXPECT_EQ("ID_CLOUD_PRINT", id_cloud_print);
+  EXPECT_EQ("SECRET_CLOUD_PRINT", secret_cloud_print);
+  EXPECT_EQ("ID_REMOTING", id_remoting);
+  EXPECT_EQ("SECRET_REMOTING", secret_remoting);
+}
+
+// Override all keys using both preprocessor defines and environment
+// variables.  The environment variables should win.
+namespace override_all_keys_env {
+
+// We start every test by creating a clean environment for the
+// preprocessor defines used in google_api_keys.cc
+#undef DUMMY_API_TOKEN
+#undef GOOGLE_API_KEY
+#undef GOOGLE_CLIENT_ID_MAIN
+#undef GOOGLE_CLIENT_SECRET_MAIN
+#undef GOOGLE_CLIENT_ID_CLOUD_PRINT
+#undef GOOGLE_CLIENT_SECRET_CLOUD_PRINT
+#undef GOOGLE_CLIENT_ID_REMOTING
+#undef GOOGLE_CLIENT_SECRET_REMOTING
+#undef GOOGLE_DEFAULT_CLIENT_ID
+#undef GOOGLE_DEFAULT_CLIENT_SECRET
+
+#define GOOGLE_API_KEY "API_KEY"
+#define GOOGLE_CLIENT_ID_MAIN "ID_MAIN"
+#define GOOGLE_CLIENT_SECRET_MAIN "SECRET_MAIN"
+#define GOOGLE_CLIENT_ID_CLOUD_PRINT "ID_CLOUD_PRINT"
+#define GOOGLE_CLIENT_SECRET_CLOUD_PRINT "SECRET_CLOUD_PRINT"
+#define GOOGLE_CLIENT_ID_REMOTING "ID_REMOTING"
+#define GOOGLE_CLIENT_SECRET_REMOTING "SECRET_REMOTING"
+
+// Undef include guard so things get defined again, within this namespace.
+#undef GOOGLE_APIS_GOOGLE_API_KEYS_H_
+#undef GOOGLE_APIS_INTERNAL_GOOGLE_CHROME_API_KEYS_
+#include "google_apis/google_api_keys.cc"
+
+}  // namespace override_all_keys_env
+
+TEST_F(GoogleAPIKeysTest, OverrideAllKeysUsingEnvironment) {
+  namespace testcase = override_all_keys_env::google_apis;
+
+  scoped_ptr<base::Environment> env(base::Environment::Create());
+  env->SetVar("GOOGLE_API_KEY", "env-API_KEY");
+  env->SetVar("GOOGLE_CLIENT_ID_MAIN", "env-ID_MAIN");
+  env->SetVar("GOOGLE_CLIENT_ID_CLOUD_PRINT", "env-ID_CLOUD_PRINT");
+  env->SetVar("GOOGLE_CLIENT_ID_REMOTING", "env-ID_REMOTING");
+  env->SetVar("GOOGLE_CLIENT_SECRET_MAIN", "env-SECRET_MAIN");
+  env->SetVar("GOOGLE_CLIENT_SECRET_CLOUD_PRINT", "env-SECRET_CLOUD_PRINT");
+  env->SetVar("GOOGLE_CLIENT_SECRET_REMOTING", "env-SECRET_REMOTING");
+
+  // It's important that the first call to Get() only happen after the
+  // environment variables have been set.
+  std::string api_key = testcase::g_api_key_cache.Get().api_key();
+  std::string id_main = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_MAIN);
+  std::string secret_main = testcase::g_api_key_cache.Get().GetClientSecret(
+      testcase::CLIENT_MAIN);
+  std::string id_cloud_print =
+      testcase::g_api_key_cache.Get().GetClientID(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string secret_cloud_print =
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_CLOUD_PRINT);
+  std::string id_remoting = testcase::g_api_key_cache.Get().GetClientID(
+      testcase::CLIENT_REMOTING);
+  std::string secret_remoting =
+      testcase::g_api_key_cache.Get().GetClientSecret(
+          testcase::CLIENT_REMOTING);
+
+  EXPECT_EQ("env-API_KEY", api_key);
+  EXPECT_EQ("env-ID_MAIN", id_main);
+  EXPECT_EQ("env-SECRET_MAIN", secret_main);
+  EXPECT_EQ("env-ID_CLOUD_PRINT", id_cloud_print);
+  EXPECT_EQ("env-SECRET_CLOUD_PRINT", secret_cloud_print);
+  EXPECT_EQ("env-ID_REMOTING", id_remoting);
+  EXPECT_EQ("env-SECRET_REMOTING", secret_remoting);
+}