Views fuzzing for Aura and Windows

ui/views/view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_VIEW_H_
 #define UI_VIEWS_VIEW_H_
 
 #include <algorithm>
 #include <map>
 #include <set>
@@ skipping 392 matching lines @@
 
   // Convert a point from the coordinate system of one View to another.
   //
   // |source| and |target| must be in the same widget, but doesn't need to be in
   // the same view hierarchy.
   // |source| can be NULL in which case it means the screen coordinate system.
   static void ConvertPointToTarget(const View* source,
                                    const View* target,
                                    gfx::Point* point);
 
+  // Convert |rect| from the coordinate system of one View to another.
+  //
+  // |source| and |target| must be in the same widget, but doesn't need to be in
+  // the same view hierarchy.
+  // |source| can be NULL in which case it means the screen coordinate system.
+  static void ConvertRectToTarget(const View* source,
+                                   const View* target,
+                                   gfx::Rect* rect);

[tdanderson, 2012/09/18 19:19:02]

nit: spacing

+
   // Convert a point from a View's coordinate system to that of its Widget.
   static void ConvertPointToWidget(const View* src, gfx::Point* point);
 
   // Convert a point from the coordinate system of a View's Widget to that
   // View's coordinate system.
   static void ConvertPointFromWidget(const View* dest, gfx::Point* p);
 
   // Convert a point from a View's coordinate system to that of the screen.
   static void ConvertPointToScreen(const View* src, gfx::Point* point);
 
@@ skipping 70 matching lines @@
 
   // Enable/Disable accelerated compositing.
   static void set_use_acceleration_when_possible(bool use);
   static bool get_use_acceleration_when_possible();
 
   // Input ---------------------------------------------------------------------
   // The points (and mouse locations) in the following functions are in the
   // view's coordinates, except for a RootView.
 
   // Returns the deepest visible descendant that contains the specified point.
-  virtual View* GetEventHandlerForPoint(const gfx::Point& point);
+  View* GetEventHandlerForPoint(const gfx::Point& point);
+
+  // Returns the appropriate event handler for the given touch rect.

[sky, 2012/09/18 19:51:41]

If this is specific to touch, it should be named so, eg GetEventHandlerForTouch.

+  View* GetEventHandlerForRect(const gfx::Rect& rect);
 
   // Return the cursor that should be used for this view or the default cursor.
   // The event location is in the receiver's coordinate system. The caller is
   // responsible for managing the lifetime of the returned object, though that
   // lifetime may vary from platform to platform. On Windows and Aura,
   // the cursor is a shared resource.
   virtual gfx::NativeCursor GetCursor(const ui::MouseEvent& event);
 
   // A convenience function which calls HitTestRect() with a rect of size
   // 1x1 and an origin of |point|.
@@ skipping 520 matching lines @@
 
   // Called by HitTestRect() to see if this View has a custom hit test mask. If
   // the return value is true, GetHitTestMask() will be called to obtain the
   // mask. Default value is false, in which case the View will hit-test against
   // its bounds.
   virtual bool HasHitTestMask() const;
 
   // Called by HitTestRect() to retrieve a mask for hit-testing against.
   // Subclasses override to provide custom shaped hit test regions.
   virtual void GetHitTestMask(gfx::Path* mask) const;
+public:

[girard, 2012/09/18 16:58:52]

make protected.
This will mess up all the other headers, but it's the right thing to do.

[sky, 2012/09/18 19:51:41]

Huh? Move the enum and function to the right sections. Arbitrarily adding new
sections doesn't scale.

+  // Flags the event type, so that a single GetEvent routine can handle both.
+  enum EventType { MOUSE, TOUCH };

[sky, 2012/09/18 19:51:41]

Make these more descriptive. Maybe EventHandlerType EVENT_HANDLER_TYPE_MOUSE and
EVENT_HANDLER_TYPE_TOUCH.

 
+  // Returns the appropriate event handler for the given |rect|. Location will
+  // either be a rect (for a touch event) or a point (as a 1X1 rect) for a
+  // mouse event.
+  // Considers the bounding rectangles of all leaf descendant views that have
+  // at least views::kFuzzingOverlapPercentage of their area covered by
+  // |rect|. Among these rectangles, choose one that is closest to the center
+  // line of |rect| and return its corresponding View. If there are no such
+  // rectangles, NULL is returned.

[tdanderson, 2012/09/18 19:19:02]

I think this description is from my old patch. Are you still planning on using
the kFuzzingOverlapPercentage threshold in any way?

+  virtual View* GetEventHandler(const gfx::Rect& rect, EventType type);
+protected:
   // Focus ---------------------------------------------------------------------
 
   // Override to be notified when focus has changed either to or from this View.
   virtual void OnFocus();
   virtual void OnBlur();
 
   // Handle view focus/blur events for this view.
   void Focus();
   void Blur();
 
@@ skipping 417 matching lines @@
   base::win::ScopedComPtr<NativeViewAccessibilityWin>
       native_view_accessibility_win_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(View);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_VIEW_H_