FYI: Remove PerModelSafeGroupState + move ConflictResolution

sync/sessions/status_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// FIXME: rewrite this comment.
 // StatusController handles all counter and status related number crunching and
 // state tracking on behalf of a SyncSession.  It 'controls' the model data
 // defined in session_state.h.  The most important feature of StatusController
 // is the ScopedModelSafetyRestriction. When one of these is active, the
 // underlying data set exposed via accessors is swapped out to the appropriate
 // set for the restricted ModelSafeGroup behind the scenes.  For example, if
 // GROUP_UI is set, then accessors such as conflict_progress() and commit_ids()
 // are implicitly restricted to returning only data pertaining to GROUP_UI.
 // You can see which parts of status fall into this "restricted" category, or
 // the global "shared" category for all model types, by looking at the struct
@@ skipping 18 matching lines @@
 #define SYNC_SESSIONS_STATUS_CONTROLLER_H_
 
 #include <map>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/time.h"
 #include "sync/internal_api/public/sessions/model_neutral_state.h"
 #include "sync/sessions/ordered_commit_set.h"
-#include "sync/sessions/session_state.h"
 
 namespace syncer {
 namespace sessions {
 
 class StatusController {
  public:
   explicit StatusController(const ModelSafeRoutingInfo& routes);
   ~StatusController();
 
-  // Progress counters.  All const methods may return NULL if the
-  // progress structure doesn't exist, but all non-const methods
-  // auto-create.
-  const ConflictProgress* conflict_progress() const;
-  ConflictProgress* mutable_conflict_progress();
-  const UpdateProgress* update_progress() const;
-  UpdateProgress* mutable_update_progress();
-  const ConflictProgress* GetUnrestrictedConflictProgress(
-      ModelSafeGroup group) const;
-  ConflictProgress* GetUnrestrictedMutableConflictProgressForTest(
-      ModelSafeGroup group);
-  const UpdateProgress* GetUnrestrictedUpdateProgress(
-      ModelSafeGroup group) const;
-  UpdateProgress* GetUnrestrictedMutableUpdateProgressForTest(
-      ModelSafeGroup group);
-
   // ClientToServer messages.
   const ModelTypeSet updates_request_types() const {
     return model_neutral_.updates_request_types;
   }
   void set_updates_request_types(ModelTypeSet value) {
     model_neutral_.updates_request_types = value;
   }
   const sync_pb::ClientToServerResponse& updates_response() const {
     return model_neutral_.updates_response;
   }
   sync_pb::ClientToServerResponse* mutable_updates_response() {
     return &model_neutral_.updates_response;
   }
 
   // Changelog related state.
   int64 num_server_changes_remaining() const {
     return model_neutral_.num_server_changes_remaining;
   }
 
   const OrderedCommitSet::Projection& commit_id_projection(
       const sessions::OrderedCommitSet &commit_set) {
     DCHECK(group_restriction_in_effect_)
         << "No group restriction for projection.";
     return commit_set.GetCommitIdProjection(group_restriction_);
   }
 
-  // Control parameters for sync cycles.
-  bool conflicts_resolved() const {
-    return model_neutral_.conflicts_resolved;
-  }
+  // Various conflict counters.  
+  // FIXME: probably unnecessary.  Maybe should just access members directly?
+  int num_encryption_conflicts() const;
+  int num_hierarchy_conflicts() const;
+  int num_server_conflicts() const;
 
-  // If a GetUpdates for any data type resulted in downloading an update that
-  // is in conflict, this method returns true.
-  // Note: this includes unresolvable conflicts.
-  bool HasConflictingUpdates() const;
+  // Aggregate sum of all conflict types.
+  int TotalNumConflictingItems() const;
 
-  // Aggregate sums of various types of conflict counters accross all
-  // ConflictProgress objects (one for each ModelSafeGroup currently in-use).
-  int TotalNumEncryptionConflictingItems() const;
-  int TotalNumHierarchyConflictingItems() const;
-  int TotalNumServerConflictingItems() const;
-  int TotalNumSimpleConflictingItems() const;
+  // Number of successfully applied updates.
+  int num_updates_applied() const;
 
-  // Aggregate sum of SimpleConflictingItemSize() and other
-  // ${Type}ConflictingItemSize() methods over all ConflictProgress objects (one
-  // for each ModelSafeGroup currently in-use).
-  int TotalNumConflictingItems() const;
+  int num_server_overwrites() const;
 
   // Returns the number of updates received from the sync server.
   int64 CountUpdates() const;
 
   // Returns true if the last download_updates_command received a valid
   // server response.
   bool download_updates_succeeded() const {
     return model_neutral_.last_download_updates_result
         == SYNCER_OK;
   }
@@ skipping 18 matching lines @@
   bool HasBookmarkCommitActivity() const {
     return ActiveGroupRestrictionIncludesModel(BOOKMARKS);
   }
 
   const ModelNeutralState& model_neutral_state() const {
     return model_neutral_;
   }
 
   SyncerError last_get_key_result() const;
 
-  // A toolbelt full of methods for updating counters and flags.
+  // Download counters.
   void set_num_server_changes_remaining(int64 changes_remaining);
-  void set_num_successful_bookmark_commits(int value);
-  void increment_num_successful_commits();
-  void increment_num_successful_bookmark_commits();
   void increment_num_updates_downloaded_by(int value);
   void increment_num_tombstone_updates_downloaded_by(int value);
   void increment_num_reflected_updates_downloaded_by(int value);
-  void set_types_needing_local_migration(ModelTypeSet types);
+
+  // Update application and conflict resolution counters.
+  void increment_num_updates_applied_by(int value);
+  void increment_num_encryption_conflicts_by(int value);
+  void increment_num_hierarchy_conflicts_by(int value);
+  void increment_num_server_conflicts();
   void increment_num_local_overwrites();
   void increment_num_server_overwrites();
+
+  // Commit counters.
+  void increment_num_successful_commits();
+  void increment_num_successful_bookmark_commits();
+  void set_num_successful_bookmark_commits(int value);
+
+  // Server communication status tracking.
   void set_sync_protocol_error(const SyncProtocolError& error);
   void set_last_get_key_result(const SyncerError result);
   void set_last_download_updates_result(const SyncerError result);
   void set_commit_result(const SyncerError result);
 
-  void update_conflicts_resolved(bool resolved);
-  void reset_conflicts_resolved();
+  // A very important flag used to inform frontend of need to migrate.
+  void set_types_needing_local_migration(ModelTypeSet types);
 
   void UpdateStartTime();
 
   void set_debug_info_sent();
 
   bool debug_info_sent() const;
 
  private:
   friend class ScopedModelSafeGroupRestriction;
 
   // Check whether a particular model is included by the active group
   // restriction.
   bool ActiveGroupRestrictionIncludesModel(ModelType model) const {
     if (!group_restriction_in_effect_)
       return true;
     ModelSafeRoutingInfo::const_iterator it = routing_info_.find(model);
     if (it == routing_info_.end())
       return false;
     return group_restriction() == it->second;
   }
 
-  // Returns the state, if it exists, or NULL otherwise.
-  const PerModelSafeGroupState* GetModelSafeGroupState(
-      bool restrict, ModelSafeGroup group) const;
-
-  // Helper to lazily create objects for per-ModelSafeGroup state.
-  PerModelSafeGroupState* GetOrCreateModelSafeGroupState(
-      bool restrict, ModelSafeGroup group);
-
   ModelNeutralState model_neutral_;
-  std::map<ModelSafeGroup, PerModelSafeGroupState*> per_model_group_;
-
-  STLValueDeleter<std::map<ModelSafeGroup, PerModelSafeGroupState*> >
-      per_model_group_deleter_;
 
   // Used to fail read/write operations on state that don't obey the current
   // active ModelSafeWorker contract.
   bool group_restriction_in_effect_;
   ModelSafeGroup group_restriction_;
 
   const ModelSafeRoutingInfo routing_info_;
 
   base::Time sync_start_time_;
 
@@ skipping 17 matching lines @@
   }
  private:
   StatusController* status_;
   DISALLOW_COPY_AND_ASSIGN(ScopedModelSafeGroupRestriction);
 };
 
 }  // namespace sessions
 }  // namespace syncer
 
 #endif  // SYNC_SESSIONS_STATUS_CONTROLLER_H_