FYI: Remove PerModelSafeGroupState + move ConflictResolution

sync/engine/apply_updates_command.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/engine/apply_updates_command.h"
 
 #include "base/location.h"
+#include "sync/engine/conflict_resolver.cc"
 #include "sync/engine/update_applicator.h"
 #include "sync/sessions/sync_session.h"
 #include "sync/syncable/directory.h"
 #include "sync/syncable/read_transaction.h"
 #include "sync/syncable/write_transaction.h"
 
 namespace syncer {
 
 using sessions::SyncSession;
 
@@ skipping 40 matching lines @@
   }
 
   // Don't process control type updates here.  They will be handled elsewhere.
   FullModelTypeSet control_types = ToFullModelTypeSet(ControlTypes());
   server_type_restriction.RemoveAll(control_types);
 
   std::vector<int64> handles;
   dir->GetUnappliedUpdateMetaHandles(
       &trans, server_type_restriction, &handles);
 
+  // First set of update application passes.
+  std::set<syncable::Id> simple_conflict_ids;
   UpdateApplicator applicator(
-      session->context()->resolver(),
       dir->GetCryptographer(&trans),
-      handles.begin(), handles.end(), session->routing_info(),
+      session->routing_info(),
       session->status_controller().group_restriction());
-  while (applicator.AttemptOneApplication(&trans)) {}
-  applicator.SaveProgressIntoSessionState(
-      session->mutable_status_controller()->mutable_conflict_progress(),
-      session->mutable_status_controller()->mutable_update_progress());
+  applicator.AttemptApplications(&trans, handles,
+                                 &simple_conflict_ids /* out param */);
+
+  // Resolve all simple conflicts.
+  ConflictResolver resolver;
+  resolver.ResolveConflicts(&trans,
+                            dir->GetCryptographer(&trans),
+                            simple_conflict_ids,
+                            session->mutable_status_controller());
+
+  // Conflict resolution may have cleared the way for more applications.
+  // FIXME: this will cause us to double-count encryption and hierarchy
+  // conflicts.
+  handles.clear();
+  simple_conflict_ids.clear();
+  dir->GetUnappliedUpdateMetaHandles(
+      &trans, server_type_restriction, &handles);
+  applicator.AttemptApplications(&trans, handles,
+                                 &simple_conflict_ids /* out param */);
+
+  // FIXME: This may not be correct.  We ought to loop until no simple conflicts
+  // remain.
+  DCHECK(simple_conflict_ids.empty());
+
+  applicator.SaveStats(session->mutable_status_controller());
 
   // This might be the first time we've fully completed a sync cycle, for
   // some subset of the currently synced datatypes.
   const sessions::StatusController& status(session->status_controller());
   if (status.ServerSaysNothingMoreToDownload()) {
     for (ModelTypeSet::Iterator it =
              status.updates_request_types().First(); it.Good(); it.Inc()) {
       // Don't set the flag for control types.  We didn't process them here.
       if (IsControlType(it.Get()))
         continue;
 
       // This gets persisted to the directory's backing store.
       dir->set_initial_sync_ended_for_type(it.Get(), true);
     }
   }
 
   return SYNCER_OK;
 }
 
 }  // namespace syncer