Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 10933065: Separate same domain and cross domain <link rel=...> prerenders for reporting. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: remediate in prep for CQ... Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index ced90b871758ec4d0b31c721d9883a288a732e27..e849c5d8794f750c85aef9af63bdfa8523ea1d63 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -52,10 +52,12 @@ std::string GetHistogramName(Origin origin, uint8 experiment_id,
switch (origin) {
case ORIGIN_OMNIBOX:
return ComposeHistogramName("omnibox", name);
- case ORIGIN_LINK_REL_PRERENDER:
- return ComposeHistogramName("web", name);
case ORIGIN_NONE:
dominich 2012/10/17 21:04:22 is it valid to have no origin?
return ComposeHistogramName("none", name);
+ case ORIGIN_LINK_REL_PRERENDER_SAMEDOMAIN:
+ return ComposeHistogramName("websame", name);
+ case ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN:
+ return ComposeHistogramName("webcross", name);
case ORIGIN_GWS_PRERENDER: // Handled above.
default:
NOTREACHED();
@@ -105,12 +107,14 @@ bool OriginIsOmnibox(Origin origin) {
} else if (experiment != kNoExperiment && \
(origin != ORIGIN_GWS_PRERENDER || \
experiment != recording_experiment)) { \
- } else if (origin == ORIGIN_LINK_REL_PRERENDER) { \
- HISTOGRAM; \
} else if (origin == ORIGIN_OMNIBOX) { \
HISTOGRAM; \
} else if (origin == ORIGIN_NONE) { \
HISTOGRAM; \
+ } else if (origin == ORIGIN_LINK_REL_PRERENDER_SAMEDOMAIN) { \
+ HISTOGRAM; \
+ } else if (origin == ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN) { \
+ HISTOGRAM; \
} else if (experiment != kNoExperiment) { \
HISTOGRAM; \
} else { \
@@ -120,7 +124,7 @@ bool OriginIsOmnibox(Origin origin) {
PrerenderHistograms::PrerenderHistograms()
: last_experiment_id_(kNoExperiment),
- last_origin_(ORIGIN_LINK_REL_PRERENDER),
+ last_origin_(ORIGIN_MAX),
dominich 2012/10/17 21:04:22 why is ORIGIN_NONE != ORIGIN_MAX? This suggests th
origin_experiment_wash_(false),
seen_any_pageload_(true),
seen_pageload_started_after_prerender_(true) {
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/prerender/prerender_history_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698