Separate same domain and cross domain <link rel=...> prerenders for reporting.

chrome/browser/prerender/prerender_histograms.cc

Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index 657c670ec133f6719ff0e608aa17d8350221b244..13a215ed0fce1204bf4fdfbfd18712fb9b06619e 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -46,8 +46,10 @@ std::string GetHistogramName(Origin origin, uint8 experiment_id,
   switch (origin) {
     case ORIGIN_OMNIBOX:
       return ComposeHistogramName("omnibox", name);
-    case ORIGIN_LINK_REL_PRERENDER:
-      return ComposeHistogramName("web", name);
+    case ORIGIN_LINK_REL_PRERENDER_SAMEDOMAIN:
+      return ComposeHistogramName("websame", name);
+    case ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN:
+      return ComposeHistogramName("webcross", name);
     case ORIGIN_LOCAL_PREDICTOR:
       return ComposeHistogramName("local", name);
     case ORIGIN_NONE:
@@ -101,10 +103,12 @@ bool OriginIsOmnibox(Origin origin) {
   } else if (experiment != kNoExperiment && \
              (origin != ORIGIN_GWS_PRERENDER || \
               experiment != recording_experiment)) { \
-  } else if (origin == ORIGIN_LINK_REL_PRERENDER) { \
-    HISTOGRAM; \
   } else if (origin == ORIGIN_OMNIBOX) { \

[dominich, 2012/10/08 17:03:04]

would this read better as:

} else if (origin == ORIGIN_OMNIBOX ||
           origin == ORIGIN_LINK_REL_PRERENDER_SAMEDOMAIN ||
           origin == ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN) {
  HISTOGRAM;
} ...

[gavinp, 2012/10/10 19:17:45]

It might, but then when we ran we'd have an assert fail, as three histograms
with three names each used the same static instance variable. Oh boy....

On 2012/10/08 17:03:04, dominich wrote:

     HISTOGRAM; \
+  } else if (origin == ORIGIN_LINK_REL_PRERENDER_SAMEDOMAIN) { \
+    HISTOGRAM; \
+  } else if (origin == ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN) { \
+    HISTOGRAM; \
   } else if (experiment != kNoExperiment) { \
     HISTOGRAM; \
   } else { \
@@ -114,7 +118,7 @@ bool OriginIsOmnibox(Origin origin) {
 
 PrerenderHistograms::PrerenderHistograms(base::TimeDelta prerender_ttl)
     : last_experiment_id_(kNoExperiment),
-      last_origin_(ORIGIN_LINK_REL_PRERENDER),
+      last_origin_(ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN),

[dominich, 2012/10/08 17:03:04]

worth initializing to ORIGIN_MAX so it's invalid?

[gavinp, 2012/10/10 19:17:45]

Done.

       origin_experiment_wash_(false),
       prerender_ttl_(prerender_ttl),
       seen_any_pageload_(true),