Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 10933065: Separate same domain and cross domain <link rel=...> prerenders for reporting. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: fix pending prerenders Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index 5e75a03cef4eb5f2f4e4e699546b6a56382cd4e9..a7fa97f136a04c00d7e45f086a019800dab0fe8d 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -50,8 +50,10 @@ std::string GetHistogramName(Origin origin, uint8 experiment_id,
switch (origin) {
case ORIGIN_OMNIBOX:
return ComposeHistogramName("omnibox", name);
- case ORIGIN_LINK_REL_PRERENDER:
- return ComposeHistogramName("web", name);
+ case ORIGIN_LINK_REL_PRERENDER_SAMEDOMAIN:
+ return ComposeHistogramName("websame", name);
+ case ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN:
+ return ComposeHistogramName("webcross", name);
case ORIGIN_GWS_PRERENDER: // Handled above.
default:
NOTREACHED();
@@ -101,10 +103,12 @@ bool OriginIsOmnibox(Origin origin) {
} else if (experiment != kNoExperiment && \
(origin != ORIGIN_GWS_PRERENDER || \
experiment != recording_experiment)) { \
- } else if (origin == ORIGIN_LINK_REL_PRERENDER) { \
- HISTOGRAM; \
} else if (origin == ORIGIN_OMNIBOX) { \
HISTOGRAM; \
+ } else if (origin == ORIGIN_LINK_REL_PRERENDER_SAMEDOMAIN) { \
+ HISTOGRAM; \
+ } else if (origin == ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN) { \
+ HISTOGRAM; \
} else if (experiment != kNoExperiment) { \
HISTOGRAM; \
} else { \
@@ -114,7 +118,7 @@ bool OriginIsOmnibox(Origin origin) {
PrerenderHistograms::PrerenderHistograms()
: last_experiment_id_(kNoExperiment),
- last_origin_(ORIGIN_LINK_REL_PRERENDER),
+ last_origin_(ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN),
origin_experiment_wash_(false),
seen_any_pageload_(true),
seen_pageload_started_after_prerender_(true) {
@@ -391,7 +395,7 @@ uint8 PrerenderHistograms::GetCurrentExperimentId() const {
Origin PrerenderHistograms::GetCurrentOrigin() const {
if (!WithinWindow())
- return ORIGIN_LINK_REL_PRERENDER;
+ return ORIGIN_LINK_REL_PRERENDER_CROSSDOMAIN;
return last_origin_;
}

Powered by Google App Engine
This is Rietveld 408576698