Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 10933011: [Android] Add support for layering device-located test files. (Closed)

Created:
8 years, 3 months ago by mnaganov (inactive)
Modified:
8 years, 3 months ago
Reviewers:
bulach, android-webview-reviews
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Add support for layering device-located test files. We need to split test files copied to devices by layers to avoid content or webview tests using files from chrome layer directory. To avoid modifying existing tests, test files from all layers are merged into a single directory on a device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156302

Patch Set 1 #

Total comments: 2

Patch Set 2 : Avoid merging tests on a device #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M build/android/pylib/run_java_tests.py View 1 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mnaganov (inactive)
8 years, 3 months ago (2012-09-11 03:47:03 UTC) #1
bulach
http://codereview.chromium.org/10933011/diff/1/build/android/pylib/run_java_tests.py File build/android/pylib/run_java_tests.py (right): http://codereview.chromium.org/10933011/diff/1/build/android/pylib/run_java_tests.py#newcode177 build/android/pylib/run_java_tests.py:177: cmd_helper.RunCmd(['cp', '-r', src_dir, temp_dir]) hmm.. how many tests do ...
8 years, 3 months ago (2012-09-11 10:35:06 UTC) #2
mnaganov (inactive)
https://chromiumcodereview.appspot.com/10933011/diff/1/build/android/pylib/run_java_tests.py File build/android/pylib/run_java_tests.py (right): https://chromiumcodereview.appspot.com/10933011/diff/1/build/android/pylib/run_java_tests.py#newcode177 build/android/pylib/run_java_tests.py:177: cmd_helper.RunCmd(['cp', '-r', src_dir, temp_dir]) On 2012/09/11 10:35:06, bulach wrote: ...
8 years, 3 months ago (2012-09-11 16:45:03 UTC) #3
bulach
8 years, 3 months ago (2012-09-12 15:08:40 UTC) #4
lgtm, many thanks!

Powered by Google App Engine
This is Rietveld 408576698