Add native-side unit test for Android NetworkChangeNotifier

net/base/network_change_notifier.h

Index: net/base/network_change_notifier.h
diff --git a/net/base/network_change_notifier.h b/net/base/network_change_notifier.h
index 5a40721848ad03582c94be718533fa68d35c769b..494cb04dc6fa0105aadd23ec2cbd3d438c377b51 100644
--- a/net/base/network_change_notifier.h
+++ b/net/base/network_change_notifier.h
@@ -17,6 +17,12 @@ struct DnsConfig;
 class HistogramWatcher;
 class NetworkChangeNotifierFactory;
 
+#if defined(OS_ANDROID)

[szym, 2012/09/14 19:07:29]

You shouldn't need to forward declare for friend declaration. See
NetworkChangeNotifierWinTest.

[szym, 2012/09/14 19:26:34]

:( Apparently this is not true if you want to friend a class from another
namespace.

http://stackoverflow.com/questions/4492062/why-does-a-c-friend-class-need-a-f...

[szym, 2012/09/14 19:28:38]

Still, I wonder if you need #if defined.

[gone, 2012/09/15 01:01:55]

Seems like it's fine to remove.  Had some issues with the android namespace
prior to this, so getting rid of it was kind of a boon.

+namespace android {
+class NetworkChangeNotifierAndroidTest;
+}
+#endif
+
 #if defined(OS_LINUX)
 namespace internal {
 class AddressTrackerLinux;
@@ -197,6 +203,10 @@ class NET_EXPORT NetworkChangeNotifier {
   friend class NetworkChangeNotifierLinuxTest;
   friend class NetworkChangeNotifierWinTest;
 
+#if defined(OS_ANDROID)

[szym, 2012/09/14 19:07:29]

No need for #if here.

[gone, 2012/09/15 01:01:55]

Done.

+  friend class net::android::NetworkChangeNotifierAndroidTest;
+#endif
+
   class NetworkState;
 
   // Allows a second NetworkChangeNotifier to be created for unit testing, so