ui/base/cursor/cursor_x11.cc - Issue 10928154: Fix incorrect use of UnrefCustomCursor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/cursor/cursor_x11.cc

Issue 10928154: Fix incorrect use of UnrefCustomCursor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: check if platform_cursor_ is non-zero in {Ref/Unref}CustomCursor. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/cursor/cursor_x11.cc

diff --git a/ui/base/cursor/cursor_x11.cc b/ui/base/cursor/cursor_x11.cc

index b74d03c338d3ed8b4660be18377ec027e9f89824..edf6c9bb6ba8cf7dc2403e9d9d2faa1481b5286b 100644

--- a/ui/base/cursor/cursor_x11.cc

+++ b/ui/base/cursor/cursor_x11.cc

@@ -9,11 +9,13 @@

namespace ui {

void Cursor::RefCustomCursor() {

- ui::RefCustomXCursor(platform_cursor_);

+ if (platform_cursor_)

+ ui::RefCustomXCursor(platform_cursor_);

sadrul 2012/09/12 19:46:56 Do you know where Ref/Unref is getting called but

mazda 2012/09/12 19:56:43 That's the following lines in webkit/glue/webcurso

}

void Cursor::UnrefCustomCursor() {

- ui::UnrefCustomXCursor(platform_cursor_);

+ if (platform_cursor_)

+ ui::UnrefCustomXCursor(platform_cursor_);

}

} // namespace ui

« no previous file with comments | « ui/base/cursor/cursor.cc ('k') | no next file » | no next file with comments »