Factory reset screen is added

chrome/browser/resources/chromeos/login/oobe_screen_reset.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

[Nikita (slow), 2012/09/12 13:22:21]

Please rename to screen_factory_reset.js

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Oobe eula screen implementation.

[Nikita (slow), 2012/09/12 13:22:21]

eula > reset

[glotov, 2012/09/12 22:40:25]

Done.

  */
 
 cr.define('oobe', function() {

[Nikita (slow), 2012/09/12 13:22:21]

Please place this screen into login.* namespace

[glotov, 2012/09/12 22:40:25]

Discussed above the comments.

On 2012/09/12 13:22:21, Nikita Kostylev wrote:

   /**
    * Creates a new oobe screen div.

[Nikita (slow), 2012/09/12 13:22:21]

new oobe screen div > new screen div

[glotov, 2012/09/12 22:40:25]

Done.

    * @constructor
    * @extends {HTMLDivElement}
    */
-  var EulaScreen = cr.ui.define('div');

[Nikita (slow), 2012/09/12 13:22:21]

You should probably delete this file completely locally and copy it from
somewhere else on you local fs so that it is not considered as a copy of eula
screen resources.

[glotov, 2012/09/12 22:40:25]

But it is nicer this way, no?

On 2012/09/12 13:22:21, Nikita Kostylev wrote:

[Nikita (slow), 2012/09/13 07:35:59]

No. This file should be treated as a new one even though you've based it on
existing screen.

[glotov, 2012/09/14 16:37:02]

Done.

+  var ResetScreen = cr.ui.define('div');
 
   /**
    * Registers with Oobe.
    */
-  EulaScreen.register = function() {
-    var screen = $('eula');
-    EulaScreen.decorate(screen);
+  ResetScreen.register = function() {
+    var screen = $('reset');
+    ResetScreen.decorate(screen);
     Oobe.getInstance().registerScreen(screen);
   };
 
-  EulaScreen.prototype = {
+  ResetScreen.prototype = {
     __proto__: HTMLDivElement.prototype,
 
     /** @inheritDoc */
     decorate: function() {
-      $('stats-help-link').addEventListener('click', function(event) {
-        chrome.send('eulaOnLearnMore');
-      });
     },
 
     /**
      * Header text of the screen.
      * @type {string}
      */
     get header() {
-      return localStrings.getString('eulaScreenTitle');
+      return localStrings.getString('resetScreenTitle');
     },
 
     /**
      * Buttons in oobe wizard's button strip.
      * @type {array} Array of Buttons.
      */
     get buttons() {
       var buttons = [];
 
       var backButton = this.ownerDocument.createElement('button');

[Nikita (slow), 2012/09/12 13:22:21]

backButton > cancelButton

[glotov, 2012/09/12 22:40:25]

Done.

-      backButton.id = 'back-button';
-      backButton.textContent = localStrings.getString('back');
+      backButton.id = 'reset-cancel-button';
+      backButton.textContent = localStrings.getString('cancelButton');
       backButton.addEventListener('click', function(e) {
-        chrome.send('eulaOnExit', [false, $('usage-stats').checked]);
+        chrome.send('resetOnCancel');
         e.stopPropagation();
       });
       buttons.push(backButton);
 
       var acceptButton = this.ownerDocument.createElement('button');

[Nikita (slow), 2012/09/12 13:22:21]

acceptButton > resetButton

[glotov, 2012/09/12 22:40:25]

Done.

-      acceptButton.id = 'accept-button';
-      acceptButton.textContent = localStrings.getString('acceptAgreement');
+      acceptButton.id = 'reset-button';
+      acceptButton.textContent = localStrings.getString('resetButton');
       acceptButton.addEventListener('click', function(e) {
-        chrome.send('eulaOnExit', [true, $('usage-stats').checked]);
+        chrome.send('resetOnReset');
         e.stopPropagation();
       });
       buttons.push(acceptButton);
 
       return buttons;
     }
   };
 
   return {
-    EulaScreen: EulaScreen
+    ResetScreen: ResetScreen
   };
 });