Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3350)

Unified Diff: chrome/browser/resources/help/help.js

Issue 10928061: About page UI: add confirmation message for release channel switch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Help.js only needs the this.channelName_ for chromeOS. For other OS the strings are undefined. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/help/help.js
diff --git a/chrome/browser/resources/help/help.js b/chrome/browser/resources/help/help.js
index a6bbf3333f8986d93fab5aa4ac2ee9350f248e29..0bbdc0853895ce3e4f9a6fc23880c253ca488045 100644
--- a/chrome/browser/resources/help/help.js
+++ b/chrome/browser/resources/help/help.js
@@ -54,6 +54,11 @@ cr.define('help', function() {
var channelChanger = $('channel-changer');
if (channelChanger) {
+ this.channelName_ = {
+ 'stable-channel': loadTimeData.getString('stable'),
+ 'beta-channel': loadTimeData.getString('beta'),
+ 'dev-channel': loadTimeData.getString('dev')
+ };
var self = this;
channelChanger.onchange = function(event) {
self.setReleaseChannel_(event.target.value);
@@ -215,6 +220,9 @@ cr.define('help', function() {
*/
setReleaseChannel_: function(channel) {
chrome.send('setReleaseTrack', [channel]);
+ $('channel-change-confirmation').hidden = false;
+ $('channel-change-confirmation').textContent =
+ loadTimeData.getStringF('channel-changed', this.channelName_[channel]);
James Hawkins 2012/09/09 18:08:29 nit: Indentation should be two more spaces.
hshi1 2012/09/10 06:16:57 Done.
},
/**

Powered by Google App Engine
This is Rietveld 408576698