Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: content/common/media/media_stream_options.h

Issue 10928043: Media Related changes for TabCapture API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes, fix unit tests. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/media/media_stream_options.h
diff --git a/content/common/media/media_stream_options.h b/content/common/media/media_stream_options.h
index ddd47dd0ddbb5f1a51b7b111e74a30daa4b552e5..08729ac6656a0fb2b18470fd20c8e371cabdd028 100644
--- a/content/common/media/media_stream_options.h
+++ b/content/common/media/media_stream_options.h
@@ -13,6 +13,11 @@
namespace media_stream {
+// MediaStreamConstraint keys for constraints that are passed to getUserMedia.
+CONTENT_EXPORT extern const char kMediaStreamSource[];
+CONTENT_EXPORT extern const char kMediaStreamSourceId[];
+CONTENT_EXPORT extern const char kMediaStreamSourceTab[];
+
typedef content::MediaStreamDeviceType MediaStreamType;
// StreamOptions is a Chromium representation of WebKit's
@@ -23,12 +28,16 @@ struct CONTENT_EXPORT StreamOptions {
// TODO(miu): Remove the 2-bools ctor in later clean-up CL.
StreamOptions(bool user_audio, bool user_video);
perkj_chrome 2012/10/12 13:22:05 unused? Remove this.
justinlin 2012/10/12 20:04:20 There's too many tests to update. I'll do it in a
StreamOptions(MediaStreamType audio_type, MediaStreamType video_type);
perkj_chrome 2012/10/12 13:22:05 Is this one necessary? Seems like default construc
justinlin 2012/10/12 20:04:20 Done.
+ StreamOptions(MediaStreamType audio_type, std::string audio_device_id,
perkj_chrome 2012/10/12 13:22:05 Not used in MediaStreamImpl. Remove?
justinlin 2012/10/12 20:04:20 Done.
+ MediaStreamType video_type, std::string video_device_id);
// If not NO_SERVICE, the stream shall contain an audio input stream.
MediaStreamType audio_type;
+ std::string audio_device_id;
// If not NO_SERVICE, the stream shall contain a video input stream.
MediaStreamType video_type;
+ std::string video_device_id;
};
// StreamDeviceInfo describes information about a device.

Powered by Google App Engine
This is Rietveld 408576698