Moving google_apis and GaiaClient to src/google_apis.

Moving google_apis and GaiaClient to src/google_apis.

TBR=mechanicalowners@chromium.org
BUG=145584
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155312

[Jói, 2012-09-06 04:57:46]

Hi Ben, 

Moving this as we had discussed.  Let me know if you'd like me to find someone
else to review the minutiae, assuming you're OK with the stuff I'm highlighting
below.

Most of this is mechanical updating of include paths and header guards.

Non-mechanical highlights are:
- google_apis/google_apis.gyp (main and test library targets)
- google_apis/OWNERS (set noparent, ben@ and joi@)
- google_apis/gaia/OWNERS (joaodasilva@)
- other .gyp file changes (in particular see question (a) below)
- DEPS file changes

Questions to you:

a) I'm not 100% clear on why chrome_constants referred to gaia_constants.cc; my
guess is for some reason we wanted to generate version.cc every time this (or
any of the other constants files) changed, but the version number seems the same
regardless, so I'm not sure that is really needed.

b) Are you OK with the TODO(joi) in chrome_tests.gypi, where I am executing the
unit tests from google_api as part of the 'unit_tests' target for now?  My plan
is to follow up with a change where I make this a separate target, after I
figure out what I need to coordinate with the infrastructure folks when adding a
new unit test target.

Cheers,
Jói

[Ben Goodger (Google), 2012-09-06 15:25:52]

a) me neither. svn blame is your friend :-)
b) sg. we have done that historically with a variety of other extractions. seems
like a reasonable incremental path.

lgtm


On 2012/09/06 04:57:46, Jói wrote:
> Hi Ben, 
> 
> Moving this as we had discussed.  Let me know if you'd like me to find someone
> else to review the minutiae, assuming you're OK with the stuff I'm
highlighting
> below.
> 
> Most of this is mechanical updating of include paths and header guards.
> 
> Non-mechanical highlights are:
> - google_apis/google_apis.gyp (main and test library targets)
> - google_apis/OWNERS (set noparent, ben@ and joi@)
> - google_apis/gaia/OWNERS (joaodasilva@)
> - other .gyp file changes (in particular see question (a) below)
> - DEPS file changes
> 
> Questions to you:
> 
> a) I'm not 100% clear on why chrome_constants referred to gaia_constants.cc;
my
> guess is for some reason we wanted to generate version.cc every time this (or
> any of the other constants files) changed, but the version number seems the
same
> regardless, so I'm not sure that is really needed.
> 
> b) Are you OK with the TODO(joi) in chrome_tests.gypi, where I am executing
the
> unit tests from google_api as part of the 'unit_tests' target for now?  My
plan
> is to follow up with a change where I make this a separate target, after I
> figure out what I need to coordinate with the infrastructure folks when adding
a
> new unit test target.
> 
> Cheers,
> Jói

[tim (not reviewing), 2012-09-06 16:23:27]

Hi Joi, can you please make sure rogerta@, zelidrag@, and myself are OWNERS for
the 'gaia' directory.  (Zel and I were in old browser/net/gaia, but there was
never a file added to common/net/, not sure why. And Roger is the current
resident expert on this code. sanjeevr and rickcam are no longer active here.)

Thanks!

[Jói, 2012-09-06 19:16:41]

Tim:  Done, uploaded a new version.

Ben:  the common_constants thing looking like it was supposed to be a
trigger for generating the version seems incidental, so I think the
change is good as-is.  See
http://codereview.chromium.org/267102/diff/6001/chrome/chrome.gyp?column_widt...
where the action to generate the version was introduced.

I plan to pull the trigger on the CQ in a few minutes.

Cheers,
Jói


On Thu, Sep 6, 2012 at 9:23 AM,  <tim@chromium.org> wrote:
> Hi Joi, can you please make sure rogerta@, zelidrag@, and myself are OWNERS
> for
> the 'gaia' directory.  (Zel and I were in old browser/net/gaia, but there
> was
> never a file added to common/net/, not sure why. And Roger is the current
> resident expert on this code. sanjeevr and rickcam are no longer active
> here.)
>
> Thanks!
>
> http://codereview.chromium.org/10928017/

[commit-bot: I haz the power, 2012-09-06 19:35:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10928017/5223

[commit-bot: I haz the power, 2012-09-06 19:36:29]

Failed to apply patch for remoting/host/remoting_me2me_host.cc:
While running patch -p1 --forward --force;
patching file remoting/host/remoting_me2me_host.cc
Hunk #2 FAILED at 35.
1 out of 2 hunks FAILED -- saving rejects to file
remoting/host/remoting_me2me_host.cc.rej

[commit-bot: I haz the power, 2012-09-06 20:02:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10928017/2003

[commit-bot: I haz the power, 2012-09-07 04:26:40]

Change committed as 155312