Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/views/tabbed_pane.cc

Issue 10925: Fix erase method usage on STL containers in Chrome. Invoking erase on the ite... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/importer/firefox_importer_utils.cc ('K') | « chrome/browser/resource_dispatcher_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/views/tabbed_pane.cc
===================================================================
--- chrome/views/tabbed_pane.cc (revision 5528)
+++ chrome/views/tabbed_pane.cc (working copy)
@@ -120,9 +120,10 @@
ResizeContents(tab_control_);
std::vector<View*>::iterator iter = tab_views_.begin() + index;
+ View* removed_tab = *iter;
tab_views_.erase(iter);
- return *iter;
+ return removed_tab;
}
void TabbedPane::SelectTabAt(int index) {
« chrome/browser/importer/firefox_importer_utils.cc ('K') | « chrome/browser/resource_dispatcher_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698