Fix erase method usage on STL containers in Chrome. Invoking erase on the ite...

chrome/browser/resource_dispatcher_host.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is the browser side of the resource dispatcher, it receives requests
 // from the RenderProcessHosts, and dispatches them to URLRequests. It then
 // fowards the messages from the URLRequests back to the correct process for
 // handling.
 //
 // See http://wiki.corp.google.com/twiki/bin/view/Main/ChromeMultiProcessResourceLoading
@@ skipping 396 matching lines @@
   // mechanism. We should also consider a hashtable or binary tree if it turns
   // out we have a lot of things here.
   typedef std::map<GlobalRequestID,URLRequest*> PendingRequestList;
 
   // A test to determining whether a given request should be forwarded to the
   // download thread.
   bool ShouldDownload(const std::string& mime_type,
                       const std::string& content_disposition);
 
   void RemovePendingRequest(int render_process_host_id, int request_id);
-  void RemovePendingRequest(PendingRequestList::iterator& iter);
+  // Deletes the pending request identified by the iterator passed in.
+  // This function will invalidate the iterator passed in. Callers should
+  // not rely on this iterator being valid on return.
+  void RemovePendingRequest(const PendingRequestList::iterator& iter);
 
   // Notify our observers that we started receiving a response for a request.
   void NotifyResponseStarted(URLRequest* request, int render_process_host_id);
 
   // Notify our observers that a request has been cancelled.
   void NotifyResponseCompleted(URLRequest* request, int render_process_host_id);
 
   // Notify our observers that a request has been redirected.
   void NofityReceivedRedirect(URLRequest* request,
                               int render_process_host_id,
@@ skipping 53 matching lines @@
   // For running tasks.
   ScopedRunnableMethodFactory<ResourceDispatcherHost> method_runner_;
 
   // True if the resource dispatcher host has been shut down.
   bool is_shutdown_;
 
   DISALLOW_EVIL_CONSTRUCTORS(ResourceDispatcherHost);
 };
 
 #endif  // CHROME_BROWSER_RESOURCE_DISPATCHER_HOST_H__