lib/compiler/implementation/compiler.dart - Issue 10920089: Generate a warning and a runtime error for calls to nonexistent static calls, getters and setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10920089: Generate a warning and a runtime error for calls to nonexistent static calls, getters and setters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | lib/compiler/implementation/dart_backend/placeholder_collector.dart » ('j') | lib/compiler/implementation/elements/elements.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/compiler.dart

diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart

index af7c95d9a22ff6ddaac7734c6014c5778adc077d..0776c18451391c786bf7ca2a130d69e6e79b32c3 100644

--- a/lib/compiler/implementation/compiler.dart

+++ b/lib/compiler/implementation/compiler.dart

@@ -824,6 +824,9 @@ class Compiler implements DiagnosticListener {

}

SourceSpan spanFromElement(Element element) {

+ if (Element.isErroneousElement(element)) {

ngeoffray 2012/09/07 08:12:46 Instead of special casing here, could you implemen

karlklose 2012/09/07 09:24:01 I wanted it to be similar to the case for the othe

ahe 2012/09/07 12:18:53 I don't think you're supposed to call spanFromElem

+ element = element.enclosingElement;

+ }

if (element.position() === null) {

// Sometimes, the backend fakes up elements that have no

// position. So we use the enclosing element instead. It is

« no previous file with comments | « no previous file | lib/compiler/implementation/dart_backend/placeholder_collector.dart » ('j') | lib/compiler/implementation/elements/elements.dart » ('J')