Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: content/browser/fileapi/fileapi_message_filter.cc

Issue 10920087: Update callers of CreateFileSystemOperation so more detailed error codes can be returned. Where app… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/fileapi/fileapi_message_filter.cc
diff --git a/content/browser/fileapi/fileapi_message_filter.cc b/content/browser/fileapi/fileapi_message_filter.cc
index 70ffc75bc58a42497066b1bcb0347c912ce82ba0..c36a6e12ac26404426254a4f08af18b245f51cdb 100644
--- a/content/browser/fileapi/fileapi_message_filter.cc
+++ b/content/browser/fileapi/fileapi_message_filter.cc
@@ -136,8 +136,10 @@ void FileAPIMessageFilter::OnChannelClosing() {
open_filesystem_urls_.begin();
iter != open_filesystem_urls_.end(); ++iter) {
FileSystemURL url(*iter);
- FileSystemOperation* operation = context_->CreateFileSystemOperation(url);
- operation->NotifyCloseFile(url);
+ FileSystemOperation* operation = context_->CreateFileSystemOperation(
+ url, NULL);
+ if (operation)
+ operation->NotifyCloseFile(url);
}
}
@@ -449,7 +451,8 @@ void FileAPIMessageFilter::OnNotifyCloseFile(const GURL& path) {
// Do not use GetNewOperation() here, because NotifyCloseFile is a one-way
// operation that does not have request_id by which we respond back.
- FileSystemOperation* operation = context_->CreateFileSystemOperation(url);
+ FileSystemOperation* operation = context_->CreateFileSystemOperation(
+ url, NULL);
if (operation)
operation->NotifyCloseFile(url);
}
@@ -493,7 +496,8 @@ void FileAPIMessageFilter::OnSyncGetPlatformPath(
// TODO(kinuko): this hack should go away once appropriate upload-stream
// handling based on element types is supported.
LocalFileSystemOperation* operation =
- context_->CreateFileSystemOperation(url)->AsLocalFileSystemOperation();
+ context_->CreateFileSystemOperation(
+ url, NULL)->AsLocalFileSystemOperation();
DCHECK(operation);
operation->SyncGetPlatformPath(url, platform_path);
}
@@ -793,7 +797,7 @@ FileSystemOperation* FileAPIMessageFilter::GetNewOperation(
const FileSystemURL& target_url,
int request_id) {
FileSystemOperation* operation =
- context_->CreateFileSystemOperation(target_url);
+ context_->CreateFileSystemOperation(target_url, NULL);
DCHECK(operation);
operations_.AddWithID(operation, request_id);
return operation;

Powered by Google App Engine
This is Rietveld 408576698