Update callers of CreateFileSystemOperation so more detailed error codes can be returned. Where app…

webkit/fileapi/file_system_dir_url_request_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_dir_url_request_job.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 62 matching lines @@
 
 bool FileSystemDirURLRequestJob::GetCharset(std::string* charset) {
   *charset = "utf-8";
   return true;
 }
 
 void FileSystemDirURLRequestJob::StartAsync() {
   if (!request_)
     return;
   url_ = FileSystemURL(request_->url());
   FileSystemOperation* operation = GetNewOperation();

[kinuko, 2012/09/06 09:15:10]

Please let GetNewOperation return error code too

[calvinlo, 2012/09/06 11:19:32]

Done.

   if (!operation) {
     NotifyDone(URLRequestStatus(URLRequestStatus::FAILED,
                                 net::ERR_INVALID_URL));

[kinuko, 2012/09/06 09:15:10]

...and return the error code here (via PlatformFileErrorToNetError)

[calvinlo, 2012/09/06 11:19:32]

Done.

     return;
   }
   operation->ReadDirectory(
       url_,
       base::Bind(&FileSystemDirURLRequestJob::DidReadDirectory, this));
 }
 
 void FileSystemDirURLRequestJob::DidReadDirectory(
     base::PlatformFileError result,
     const std::vector<base::FileUtilProxy::Entry>& entries,
@@ skipping 20 matching lines @@
 
   typedef std::vector<base::FileUtilProxy::Entry>::const_iterator EntryIterator;
   for (EntryIterator it = entries.begin(); it != entries.end(); ++it) {
     const string16& name = FilePath(it->name).LossyDisplayName();
     data_.append(net::GetDirectoryListingEntry(
         name, std::string(), it->is_directory, it->size,
         it->last_modified_time));
   }
 
   if (has_more) {
     GetNewOperation()->ReadDirectory(

[kinuko, 2012/09/06 09:15:10]

ditto.  We need to fail (with NotifyDone) if the operation is null.

[calvinlo, 2012/09/06 11:19:32]

Done.

         url_,
         base::Bind(&FileSystemDirURLRequestJob::DidReadDirectory, this));
   } else {
     set_expected_content_size(data_.size());
     NotifyHeadersComplete();
   }
 }
 
 FileSystemOperation* FileSystemDirURLRequestJob::GetNewOperation() {
-  return file_system_context_->CreateFileSystemOperation(url_);
+  return file_system_context_->CreateFileSystemOperation(url_, NULL);
 }
 
 }  // namespace fileapi