Update callers of CreateFileSystemOperation so more detailed error codes can be returned. Where app…

webkit/fileapi/file_system_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_context.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/stl_util.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 165 matching lines @@
       GetMountPointProvider(type);
   if (!mount_point_provider) {
     callback.Run(base::PLATFORM_FILE_ERROR_SECURITY);
     return;
   }
 
   mount_point_provider->DeleteFileSystem(origin_url, type, this, callback);
 }
 
 FileSystemOperation* FileSystemContext::CreateFileSystemOperation(
-    const FileSystemURL& url) {
-  if (!url.is_valid())
+    const FileSystemURL& url, PlatformFileError* error_code) {
+  if (!url.is_valid()) {
+    if (error_code)
+      *error_code = base::PLATFORM_FILE_ERROR_INVALID_URL;
     return NULL;
+  }
   FileSystemMountPointProvider* mount_point_provider =
       GetMountPointProvider(url.type());
-  if (!mount_point_provider)
+  if (!mount_point_provider) {
+    if (error_code)
+      *error_code = base::PLATFORM_FILE_ERROR_FAILED;
     return NULL;
+  }
+
+  if (error_code)
+    *error_code = base::PLATFORM_FILE_OK;
   return mount_point_provider->CreateFileSystemOperation(url, this);
 }
 
 webkit_blob::FileStreamReader* FileSystemContext::CreateFileStreamReader(
     const FileSystemURL& url,
     int64 offset) {
+

[kinuko, 2012/09/06 09:15:10]

nit: please remove this empty line

[calvinlo, 2012/09/06 11:19:32]

Done.

   if (!url.is_valid())
     return NULL;
   FileSystemMountPointProvider* mount_point_provider =
       GetMountPointProvider(url.type());
   if (!mount_point_provider)
     return NULL;
   return mount_point_provider->CreateFileStreamReader(url, offset, this);
 }
 
 void FileSystemContext::RegisterMountPointProvider(
@@ skipping 10 matching lines @@
   if (!task_runners_->io_task_runner()->RunsTasksOnCurrentThread() &&
       task_runners_->io_task_runner()->DeleteSoon(FROM_HERE, this)) {
     return;
   }
   STLDeleteContainerPairSecondPointers(provider_map_.begin(),
                                        provider_map_.end());
   delete this;
 }
 
 }  // namespace fileapi