Chromium Code Reviews

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 10920033: Implement Android WebView BlockNetworkImages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update ContentSetting to new locking semantics. Add a test that does not require http server. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
index 666454f1a287fd22ccd56329500b829ceca6153c..759edfcc7f37a7e1b14900753f2f106c833b1e1f 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
@@ -1339,4 +1339,32 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
private String createContentUrl(final String target) {
return TestContentProvider.createContentUrl(target);
}
+
+ private final String DATA_URL_IMAGE_HTML = "<html>" +
+ "<head><script>function updateTitle(){" +
+ "document.title=document.getElementById('img').naturalHeight;}</script></head>" +
+ "<body onload='updateTitle()'>" +
+ "<img id='img' onload='updateTitle()' src='data:image/png;base64,iVBORw0KGgoAAA" +
+ "ANSUhEUgAAAAEAAAABCAAAAAA6fptVAAAAAXNSR0IArs4c6QAAAA1JREFUCB0BAgD9/wAAAAIAAc3j" +
+ "0SsAAAAASUVORK5CYII=" +
+ "'></body></html>";
+
+ @SmallTest
+ @Feature({"Android-WebView", "Preferences"})
+ public void testBlockNetworkImagesDoesNotBlockDataUrlImage() throws Throwable {
+ final TestAwContentsClient contentClient = new TestAwContentsClient();
+ final ContentViewCore contentView =
+ createAwTestContainerViewOnMainSync(false, contentClient).getContentViewCore();
+ final ContentSettings settings = getContentSettingsOnUiThread(contentView);
+
+ settings.setJavaScriptEnabled(true);
+
+ settings.setImagesEnabled(false);
+ loadDataSync(contentView,
+ contentClient.getOnPageFinishedHelper(),
+ DATA_URL_IMAGE_HTML,
+ "text/html",
+ false);
+ assertEquals("1", getTitleOnUiThread(contentView));
+ }
}

Powered by Google App Engine