Issue 10919162:
[MIPS] Implementation of sel_ldr for MIPS architecture. (Closed)
Base URL: http://src.chromium.org/native_client/trunk/src/native_client/
Patch Set:
Created 8 years, 3 months ago
Use n/p to move between diff chunks;
N/P to move between comments.
Draft comments are only viewable by you.
Mark Seaborn
2012/09/08 02:43:14
We normally use 1-char spacing for indenting #ifs,
We normally use 1-char spacing for indenting #ifs, i.e.
#if FOO
# if BAR
# if QUX
...
# endif
# endif
#endif
+# undef __WORDSIZE
+# endif
+# define __WORDSIZE 32
Mark Seaborn
2012/09/08 02:43:14
Why redefine this? Won't this mess with whatever
Why redefine this? Won't this mess with whatever the host toolchain uses? Does
NaCl actually use __WORDSIZE, and if so, can we clean it up so that it doesn't?
petarj
2012/09/11 16:58:13
Ok, the MIPS host toolchain will set it to 32 anyw
On 2012/09/08 02:43:14, Mark Seaborn wrote:
> Why redefine this? Won't this mess with whatever the host toolchain uses?
Does
> NaCl actually use __WORDSIZE, and if so, can we clean it up so that it
doesn't?
Ok, the MIPS host toolchain will set it to 32 anyway. I will just add the code
that prevents redefinition.
Issue 10919162: [MIPS] Implementation of sel_ldr for MIPS architecture.
(Closed)
Created 8 years, 3 months ago by petarj
Modified 8 years, 3 months ago
Reviewers: Brad Chen, Robert Muth (chromium), Mark Seaborn
Base URL: http://src.chromium.org/native_client/trunk/src/native_client/
Comments: 127
Chromium Code Reviews
Issue 10919162:
[MIPS] Implementation of sel_ldr for MIPS architecture. (Closed)
Base URL: http://src.chromium.org/native_client/trunk/src/native_client/