Chromium Code Reviews| Index: src/trusted/service_runtime/arch/mips/sel_ldr_mips.h | 
| diff --git a/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h b/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h | 
| new file mode 100644 | 
| index 0000000000000000000000000000000000000000..98841306523f44acc28cad6c999d6d033ccffede | 
| --- /dev/null | 
| +++ b/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h | 
| @@ -0,0 +1,36 @@ | 
| +/* | 
| + * Copyright 2012 The Native Client Authors. All rights reserved. | 
| + * Use of this source code is governed by a BSD-style license that can | 
| + * be found in the LICENSE file. | 
| + */ | 
| + | 
| +#ifndef SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ | 
| +#define SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ 1 | 
| + | 
| +#include "native_client/src/include/portability.h" | 
| +#include "native_client/src/trusted/service_runtime/nacl_config.h" | 
| + | 
| +#define NACL_MAX_ADDR_BITS 30 | 
| + | 
| +#define NACL_ADDRSPACE_LOWER_GUARD_SIZE 0 | 
| +#define NACL_ADDRSPACE_UPPER_GUARD_SIZE 0x2000 | 
| + | 
| +/* Must be synced with irt_compatible_rodata_addr in SConstruct */ | 
| +#define NACL_DATA_SEGMENT_START 0x10000000 | 
| + | 
| +#define NACL_THREAD_MAX 4096 | 
| 
 
Mark Seaborn
2012/09/08 02:43:14
On ARM/x86 we use 8192.  Any reason this is lower?
 
petarj
2012/09/11 16:58:13
For historical reasons. We can switch on 8192 now.
 
 | 
| + | 
| +#define NACL_NOOP_OPCODE 0x00000000 /* nop */ | 
| +#define NACL_HALT_OPCODE 0x00000008 /* jr $0 */ | 
| +#define NACL_HALT_LEN 4 /* length of halt instruction */ | 
| +#define NACL_HALT_WORD NACL_HALT_OPCODE | 
| + | 
| +struct NaClApp; | 
| +struct NaClThreadContext; | 
| + | 
| +uint32_t NaClGetThreadCombinedDescriptor(struct NaClThreadContext *user); | 
| 
 
Mark Seaborn
2012/09/08 02:43:14
This is not defined anywhere in your change.  Neit
 
petarj
2012/09/11 16:58:13
Done. (hint: you may want to remove it from the AR
 
Mark Seaborn
2012/09/13 19:44:36
Thanks for pointing that out.  I've done that in h
 
 | 
| + | 
| +void NaClSetThreadCombinedDescriptor(struct NaClThreadContext *user, | 
| + uint32_t tls_idx); | 
| + | 
| +#endif /* SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ */ |