Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: src/include/nacl_base.h

Issue 10919162: [MIPS] Implementation of sel_ldr for MIPS architecture. (Closed) Base URL: http://src.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/include/nacl_base.h
diff --git a/src/include/nacl_base.h b/src/include/nacl_base.h
index 66b87b7bbeed84a501be005579b8347053a17f52..1c0c91cc1a7c9a379b4736c3fd47d428a4e3e6f3 100644
--- a/src/include/nacl_base.h
+++ b/src/include/nacl_base.h
@@ -10,6 +10,15 @@
#ifndef NATIVE_CLIENT_SRC_INCLUDE_NACL_BASE_H_
#define NATIVE_CLIENT_SRC_INCLUDE_NACL_BASE_H_ 1
+/* The following part is necessary for Mips because Mips compilers by default
Mark Seaborn 2012/09/08 02:43:14 Nit: the NaCl comment style is /* * blah... */ s
petarj 2012/09/11 16:58:13 Done.
+ * preprocess "mips" string and replace it with character '1'. To allow using
+ * "NACL_mips" macro, we need to undefine "mips" macro.
+ */
+
+#ifdef mips
+# undef mips
+#endif
+
/*
* putting extern "C" { } in header files make emacs want to indent
* everything, which looks odd. rather than putting in fancy syntax
@@ -57,8 +66,9 @@
* Avoid using 0, because "#if FOO == 0" is true if FOO is undefined, and does
* not produce a warning or error.
*/
-#define NACL_x86 1
-#define NACL_arm 2
+#define NACL_x86 1
Mark Seaborn 2012/09/08 02:43:14 Nit: no need to change the indentation on the exis
petarj 2012/09/11 16:58:13 Done.
+#define NACL_arm 2
+#define NACL_mips 3
/*****************************************************************************
* Architecture name encodings.

Powered by Google App Engine
This is Rietveld 408576698