src/trusted/service_runtime/include/bits/wordsize.h - Issue 10919162: [MIPS] Implementation of sel_ldr for MIPS architecture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/service_runtime/include/bits/wordsize.h

Issue 10919162: [MIPS] Implementation of sel_ldr for MIPS architecture. (Closed) Base URL: http://src.chromium.org/native_client/trunk/src/native_client/

Patch Set: Patch updated per Mark's comments. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2009 The Native Client Authors. All rights reserved.	2 * Copyright 2009 The Native Client Authors. All rights reserved.

3 * Use of this source code is governed by a BSD-style license that can	3 * Use of this source code is governed by a BSD-style license that can

4 * be found in the LICENSE file.	4 * be found in the LICENSE file.

5 */	5 */

6	6

7 /*	7 /*

8 * NaCl Service Runtime API.	8 * NaCl Service Runtime API.

9 */	9 */

10	10

11	11

12 #ifndef NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_INCLUDE_BITS_WORDSIZE_H_	12 #ifndef NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_INCLUDE_BITS_WORDSIZE_H_

13 #define NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_INCLUDE_BITS_WORDSIZE_H_	13 #define NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_INCLUDE_BITS_WORDSIZE_H_

14	14

15 #if defined(__powerpc64__) \|\| defined(__s390x__) \|\| defined(__arch64__) \|\| \	15 #if defined(__powerpc64__) \|\| defined(__s390x__) \|\| defined(__arch64__) \|\| \
	Mark Seaborn 2012/09/16 02:46:06 Can you enclose this whole block in "#if !defined( Can you enclose this whole block in "#if !defined(__WORDSIZE)"? That would make more sense than putting that #if into just one branch. I think the only place we use __WORDSIZE is in portability.h, but we shouldn't really use it because it's glibc-internal. petarj 2012/09/18 00:22:15 Done. Show quoted text On 2012/09/16 02:46:06, Mark Seaborn wrote: > Can you enclose this whole block in "#if !defined(__WORDSIZE)"? That would make > more sense than putting that #if into just one branch. > > I think the only place we use __WORDSIZE is in portability.h, but we shouldn't > really use it because it's glibc-internal. Done.
16 defined(__sparcv9) \|\| defined(__x86_64__) \|\| defined(_AMD64_) \|\| \	16 defined(__sparcv9) \|\| defined(__x86_64__) \|\| defined(_AMD64_) \|\| \

17 defined(_M_AMD64)	17 defined(_M_AMD64)

18 #define __WORDSIZE 64	18 #define __WORDSIZE 64

19 #else	19 #else

20 #define __WORDSIZE 32	20 # if !defined __WORDSIZE

21 #endif	21 # define __WORDSIZE 32

	22 # endif

22	23

23 #endif	24 #endif

	25 #endif

OLD	NEW