src/trusted/platform_qualify/arch/mips/nacl_qualify_fpu.c - Issue 10919162: [MIPS] Implementation of sel_ldr for MIPS architecture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/platform_qualify/arch/mips/nacl_qualify_fpu.c

Issue 10919162: [MIPS] Implementation of sel_ldr for MIPS architecture. (Closed) Base URL: http://src.chromium.org/native_client/trunk/src/native_client/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« src/trusted/platform_qualify/arch/mips/nacl_mips_qualify.h ('K') | « src/trusted/platform_qualify/arch/mips/nacl_mips_qualify.h ('k') | src/trusted/platform_qualify/build.scons » ('j') | src/trusted/service_runtime/arch/mips/nacl_syscall.S » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /*

	2 * Copyright (c) 2012 The Native Client Authors. All rights reserved.

	3 * Use of this source code is governed by a BSD-style license that can be

	4 * found in the LICENSE file.

	5 */

	6

	7 #include <setjmp.h>

	8 #include <signal.h>

	9 #include <stdint.h>

	10 #include <stdlib.h>

	11

	12 /*

	13 * Returns 1 if FPU instructions work.

	14 */

	15 int NaClQualifyFpu(void) {

	16 // TODO(petarj): Find an ellegant way to check if FPU is present
	Mark Seaborn 2012/09/08 02:43:14 Spelling: "elegant" Also, please use C-style comme Spelling: "elegant" Also, please use C-style comments. Also, why bother to declare this function if it's a no-op? You might as well omit it and make the change smaller. petarj 2012/09/11 16:58:13 Ok, file omitted for now. Show quoted text On 2012/09/08 02:43:14, Mark Seaborn wrote: > Spelling: "elegant" > Also, please use C-style comments. > Also, why bother to declare this function if it's a no-op? You might as well > omit it and make the change smaller. Ok, file omitted for now.
	17 return 1;

	18 }

OLD	NEW