Break out base functionality of UserCloudPolicyManager.

chrome/browser/policy/user_cloud_policy_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
-#include "chrome/browser/policy/cloud_policy_service.h"
-#include "chrome/browser/policy/configuration_policy_provider_test.h"
 #include "chrome/browser/policy/mock_cloud_policy_store.h"
 #include "chrome/browser/policy/mock_configuration_policy_provider.h"
 #include "chrome/browser/policy/mock_device_management_service.h"
 #include "chrome/browser/policy/proto/device_management_backend.pb.h"
 #include "chrome/browser/policy/user_cloud_policy_manager.h"

[Joao da Silva, 2012/09/07 12:44:13]

nit: first include

[Mattias Nissler (ping if slow), 2012/09/07 13:12:59]

Done.

 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/test/base/testing_pref_service.h"
 #include "policy/policy_constants.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace em = enterprise_management;
 
 using testing::AnyNumber;
 using testing::AtLeast;
 using testing::Mock;
 using testing::_;
 
 namespace policy {
 namespace {
 
-class TestHarness : public PolicyProviderTestHarness {
- public:
-  explicit TestHarness(PolicyLevel level);
-  virtual ~TestHarness();
-
-  virtual void SetUp() OVERRIDE;
-
-  virtual ConfigurationPolicyProvider* CreateProvider(
-      const PolicyDefinitionList* policy_definition_list) OVERRIDE;
-
-  virtual void InstallEmptyPolicy() OVERRIDE;
-  virtual void InstallStringPolicy(const std::string& policy_name,
-                                   const std::string& policy_value) OVERRIDE;
-  virtual void InstallIntegerPolicy(const std::string& policy_name,
-                                    int policy_value) OVERRIDE;
-  virtual void InstallBooleanPolicy(const std::string& policy_name,
-                                    bool policy_value) OVERRIDE;
-  virtual void InstallStringListPolicy(
-      const std::string& policy_name,
-      const base::ListValue* policy_value) OVERRIDE;
-  virtual void InstallDictionaryPolicy(
-      const std::string& policy_name,
-      const base::DictionaryValue* policy_value) OVERRIDE;
-
-  // Creates harnesses for mandatory and recommended levels, respectively.
-  static PolicyProviderTestHarness* CreateMandatory();
-  static PolicyProviderTestHarness* CreateRecommended();
-
- private:
-  MockCloudPolicyStore* store_;
-
-  DISALLOW_COPY_AND_ASSIGN(TestHarness);
-};
-
-TestHarness::TestHarness(PolicyLevel level)
-    : PolicyProviderTestHarness(level, POLICY_SCOPE_USER) {}
-
-TestHarness::~TestHarness() {}
-
-void TestHarness::SetUp() {}
-
-ConfigurationPolicyProvider* TestHarness::CreateProvider(
-    const PolicyDefinitionList* policy_definition_list) {
-  // Create and initialize the store.
-  store_ = new MockCloudPolicyStore();
-  store_->NotifyStoreLoaded();
-  EXPECT_CALL(*store_, Load());
-  return new UserCloudPolicyManager(scoped_ptr<CloudPolicyStore>(store_).Pass(),
-                                    false);
-}
-
-void TestHarness::InstallEmptyPolicy() {}
-
-void TestHarness::InstallStringPolicy(const std::string& policy_name,
-                                      const std::string& policy_value) {
-  store_->policy_map_.Set(policy_name, policy_level(), policy_scope(),
-                          base::Value::CreateStringValue(policy_value));
-}
-
-void TestHarness::InstallIntegerPolicy(const std::string& policy_name,
-                                       int policy_value) {
-  store_->policy_map_.Set(policy_name, policy_level(), policy_scope(),
-                          base::Value::CreateIntegerValue(policy_value));
-}
-
-void TestHarness::InstallBooleanPolicy(const std::string& policy_name,
-                                       bool policy_value) {
-  store_->policy_map_.Set(policy_name, policy_level(), policy_scope(),
-                          base::Value::CreateBooleanValue(policy_value));
-}
-
-void TestHarness::InstallStringListPolicy(const std::string& policy_name,
-                                          const base::ListValue* policy_value) {
-  store_->policy_map_.Set(policy_name, policy_level(), policy_scope(),
-                          policy_value->DeepCopy());
-}
-
-void TestHarness::InstallDictionaryPolicy(
-    const std::string& policy_name,
-    const base::DictionaryValue* policy_value) {
-  store_->policy_map_.Set(policy_name, policy_level(), policy_scope(),
-                          policy_value->DeepCopy());
-}
-
-// static
-PolicyProviderTestHarness* TestHarness::CreateMandatory() {
-  return new TestHarness(POLICY_LEVEL_MANDATORY);
-}
-
-// static
-PolicyProviderTestHarness* TestHarness::CreateRecommended() {
-  return new TestHarness(POLICY_LEVEL_RECOMMENDED);
-}
-
-// Instantiate abstract test case for basic policy reading tests.
-INSTANTIATE_TEST_CASE_P(
-    UserCloudPolicyManagerProviderTest,
-    ConfigurationPolicyProviderTest,
-    testing::Values(TestHarness::CreateMandatory,
-                    TestHarness::CreateRecommended));
-
 class UserCloudPolicyManagerTest : public testing::Test {
  protected:
   UserCloudPolicyManagerTest()
       : store_(NULL) {}
 
   virtual void SetUp() OVERRIDE {
     chrome::RegisterLocalState(&prefs_);
 
     // Set up a policy map for testing.
     policy_map_.Set("key", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                     base::Value::CreateStringValue("value"));
     expected_bundle_.Get(POLICY_DOMAIN_CHROME, std::string()).CopyFrom(
         policy_map_);
 
     // Create a fake policy blob to deliver to the client.
     em::PolicyData policy_data;
     em::PolicyFetchResponse* policy_response =
         policy_blob_.mutable_policy_response()->add_response();
     ASSERT_TRUE(policy_data.SerializeToString(
         policy_response->mutable_policy_data()));
 
     EXPECT_CALL(device_management_service_, StartJob(_, _, _, _, _, _, _))
         .Times(AnyNumber());
   }
 
   void CreateManager(bool wait_for_policy_fetch) {
     store_ = new MockCloudPolicyStore();
     EXPECT_CALL(*store_, Load());
     manager_.reset(
-        new UserCloudPolicyManager(scoped_ptr<CloudPolicyStore>(store_).Pass(),
+        new UserCloudPolicyManager(scoped_ptr<CloudPolicyStore>(store_),
                                    wait_for_policy_fetch));
     registrar_.Init(manager_.get(), &observer_);
+    Mock::VerifyAndClearExpectations(store_);
   }
 
   void CreateManagerWithPendingFetch() {
     CreateManager(true);
     manager_->Initialize(&prefs_, &device_management_service_,
                          USER_AFFILIATION_NONE);
     EXPECT_FALSE(manager_->IsInitializationComplete());
 
     // Finishing the Load() operation shouldn't set the initialized flag.
     EXPECT_CALL(observer_, OnUpdatePolicy(_)).Times(0);
@@ skipping 15 matching lines @@
   MockConfigurationPolicyObserver observer_;
   MockDeviceManagementService device_management_service_;
   MockCloudPolicyStore* store_;
   scoped_ptr<UserCloudPolicyManager> manager_;
   ConfigurationPolicyObserverRegistrar registrar_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(UserCloudPolicyManagerTest);
 };
 
-TEST_F(UserCloudPolicyManagerTest, Init) {
-  CreateManager(false);
-  PolicyBundle empty_bundle;
-  EXPECT_TRUE(empty_bundle.Equals(manager_->policies()));
-  EXPECT_FALSE(manager_->IsInitializationComplete());
-
-  store_->policy_map_.CopyFrom(policy_map_);
-  EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
-  store_->NotifyStoreLoaded();
-  EXPECT_TRUE(expected_bundle_.Equals(manager_->policies()));
-  EXPECT_TRUE(manager_->IsInitializationComplete());
-}
-
 TEST_F(UserCloudPolicyManagerTest, ShutdownAndRemovePolicy) {
   // Load policy, make sure it goes away when ShutdownAndRemove() is called.
   CreateManager(false);
   store_->policy_map_.CopyFrom(policy_map_);
   EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
   store_->NotifyStoreLoaded();
   EXPECT_TRUE(expected_bundle_.Equals(manager_->policies()));
   EXPECT_TRUE(manager_->IsInitializationComplete());
   EXPECT_CALL(*store_, Clear());
   manager_->ShutdownAndRemovePolicy();
   EXPECT_FALSE(manager_->cloud_policy_service());
 }
 
-TEST_F(UserCloudPolicyManagerTest, Update) {
-  CreateManager(false);
-  EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
-  store_->NotifyStoreLoaded();
-  EXPECT_TRUE(manager_->IsInitializationComplete());
-  PolicyBundle empty_bundle;
-  EXPECT_TRUE(empty_bundle.Equals(manager_->policies()));
-
-  store_->policy_map_.CopyFrom(policy_map_);
-  EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
-  store_->NotifyStoreLoaded();
-  EXPECT_TRUE(expected_bundle_.Equals(manager_->policies()));
-  EXPECT_TRUE(manager_->IsInitializationComplete());
-}
-
-TEST_F(UserCloudPolicyManagerTest, RefreshNotRegistered) {
-  CreateManager(false);
-  manager_->Initialize(&prefs_, &device_management_service_,
-                       USER_AFFILIATION_NONE);
-
-  EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
-  store_->NotifyStoreLoaded();
-  Mock::VerifyAndClearExpectations(&observer_);
-
-  // A refresh on a non-registered store should not block.
-  EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
-  manager_->RefreshPolicies();
-  Mock::VerifyAndClearExpectations(&observer_);
-}
-
-TEST_F(UserCloudPolicyManagerTest, RefreshSuccessful) {
-  CreateManager(false);
-  manager_->Initialize(&prefs_, &device_management_service_,
-                       USER_AFFILIATION_NONE);
-  manager_->cloud_policy_service()->client()->SetupRegistration("dm_token",
-                                                                "client_id");
-
-  EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
-  store_->NotifyStoreLoaded();
-  Mock::VerifyAndClearExpectations(&observer_);
-
-  // Start a refresh.
-  EXPECT_CALL(observer_, OnUpdatePolicy(_)).Times(0);
-  MockDeviceManagementJob* request_job;
-  EXPECT_CALL(device_management_service_,
-              CreateJob(DeviceManagementRequestJob::TYPE_POLICY_FETCH))
-      .WillOnce(device_management_service_.CreateAsyncJob(&request_job));
-  manager_->RefreshPolicies();
-  ASSERT_TRUE(request_job);
-  store_->policy_map_.CopyFrom(policy_map_);
-  Mock::VerifyAndClearExpectations(&observer_);
-
-  // A stray reload should be suppressed until the refresh completes.
-  EXPECT_CALL(observer_, OnUpdatePolicy(_)).Times(0);
-  store_->NotifyStoreLoaded();
-  Mock::VerifyAndClearExpectations(&observer_);
-
-  // Respond to the policy fetch, which should trigger a write to |store_|.
-  EXPECT_CALL(observer_, OnUpdatePolicy(_)).Times(0);
-  EXPECT_CALL(*store_, Store(_));
-  request_job->SendResponse(DM_STATUS_SUCCESS, policy_blob_);
-  Mock::VerifyAndClearExpectations(&observer_);
-
-  // The load notification from |store_| should trigger the policy update.
-  EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
-  store_->NotifyStoreLoaded();
-  EXPECT_TRUE(expected_bundle_.Equals(manager_->policies()));
-  Mock::VerifyAndClearExpectations(&observer_);
-}
-
 TEST_F(UserCloudPolicyManagerTest, WaitForPolicyFetch) {
   CreateManagerWithPendingFetch();
 
   // Setting the token should trigger the policy fetch.
   EXPECT_CALL(observer_, OnUpdatePolicy(_)).Times(0);
   MockDeviceManagementJob* fetch_request = NULL;
   EXPECT_CALL(device_management_service_,
               CreateJob(DeviceManagementRequestJob::TYPE_POLICY_FETCH))
       .WillOnce(device_management_service_.CreateAsyncJob(&fetch_request));
-  manager_->cloud_policy_service()->client()->SetupRegistration("dm_token",
-                                                                "client_id");
+  manager_->cloud_policy_client()->SetupRegistration("dm_token", "client_id");
   ASSERT_TRUE(fetch_request);
   EXPECT_FALSE(manager_->IsInitializationComplete());
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Respond to the policy fetch, which should trigger a write to |store_|.
   EXPECT_CALL(observer_, OnUpdatePolicy(_)).Times(0);
   EXPECT_CALL(*store_, Store(_));
   fetch_request->SendResponse(DM_STATUS_SUCCESS, policy_blob_);
   EXPECT_FALSE(manager_->IsInitializationComplete());
   Mock::VerifyAndClearExpectations(&observer_);
 
   // The load notification from |store_| should trigger the policy update and
   // flip the initialized bit.
   EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
   store_->NotifyStoreLoaded();
   EXPECT_TRUE(manager_->IsInitializationComplete());
   Mock::VerifyAndClearExpectations(&observer_);
 }
 
 TEST_F(UserCloudPolicyManagerTest, WaitForPolicyFetchError) {
   CreateManagerWithPendingFetch();
 
   // Setting the token should trigger the policy fetch.
   EXPECT_CALL(observer_, OnUpdatePolicy(_)).Times(0);
   MockDeviceManagementJob* fetch_request = NULL;
   EXPECT_CALL(device_management_service_,
               CreateJob(DeviceManagementRequestJob::TYPE_POLICY_FETCH))
       .WillOnce(device_management_service_.CreateAsyncJob(&fetch_request));
-  manager_->cloud_policy_service()->client()->SetupRegistration("dm_token",
-                                                                "client_id");
+  manager_->cloud_policy_client()->SetupRegistration("dm_token", "client_id");
   ASSERT_TRUE(fetch_request);
   EXPECT_FALSE(manager_->IsInitializationComplete());
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Make the policy fetch fail, at which point the manager should bail out.
   EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get())).Times(AtLeast(1));
   fetch_request->SendResponse(DM_STATUS_REQUEST_FAILED, policy_blob_);
   EXPECT_TRUE(manager_->IsInitializationComplete());
   Mock::VerifyAndClearExpectations(&observer_);
 }
 
 TEST_F(UserCloudPolicyManagerTest, WaitForPolicyFetchCancel) {
   CreateManagerWithPendingFetch();
 
   // Cancelling the initial fetch should flip the flag.
   EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
   manager_->CancelWaitForPolicyFetch();
   EXPECT_TRUE(manager_->IsInitializationComplete());
   Mock::VerifyAndClearExpectations(&observer_);
 }
 
 }  // namespace
 }  // namespace policy