Break out base functionality of UserCloudPolicyManager.

chrome/browser/policy/user_cloud_policy_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_POLICY_USER_CLOUD_POLICY_MANAGER_H_
 #define CHROME_BROWSER_POLICY_USER_CLOUD_POLICY_MANAGER_H_
 
 #include "base/basictypes.h"
+#include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/policy/cloud_policy_client.h"
 #include "chrome/browser/policy/cloud_policy_constants.h"
-#include "chrome/browser/policy/cloud_policy_store.h"
-#include "chrome/browser/policy/configuration_policy_provider.h"
+#include "chrome/browser/policy/cloud_policy_manager.h"
 
 class PrefService;
 class Profile;
 
 namespace policy {
 
 class CloudPolicyRefreshScheduler;
 class CloudPolicyService;

[Joao da Silva, 2012/09/07 12:44:13]

nit: these 2 are not used

[Mattias Nissler (ping if slow), 2012/09/07 13:12:59]

Done.

 class DeviceManagementService;
 
 // UserCloudPolicyManager keeps track of all things user policy, drives the
 // corresponding cloud policy service and publishes policy through the
 // ConfigurationPolicyProvider interface.
-class UserCloudPolicyManager : public ConfigurationPolicyProvider,
-                               public CloudPolicyClient::Observer,
-                               public CloudPolicyStore::Observer {
+class UserCloudPolicyManager : public CloudPolicyManager,
+                               public CloudPolicyClient::Observer {
  public:
   // If |wait_for_policy| fetch is true, IsInitializationComplete() will return
   // false as long as there hasn't been a successful policy fetch.
   UserCloudPolicyManager(scoped_ptr<CloudPolicyStore> store,
                          bool wait_for_policy_fetch);
   virtual ~UserCloudPolicyManager();
 
   // Creates a UserCloudPolicyService instance associated with the passed

[Joao da Silva, 2012/09/07 12:44:13]

Creates a UserCloudPolicyManager?

[Mattias Nissler (ping if slow), 2012/09/07 13:12:59]

Done.

   // |profile|.
   static scoped_ptr<UserCloudPolicyManager> Create(Profile* profile,
                                                    bool wait_for_policy_fetch);
 
-  // Initializes the cloud connection. |local_prefs| and |service| must stay
+  // Initializes the cloud connection. |local_state| and |service| must stay
   // valid until this object is deleted or ShutdownAndRemovePolicy() gets
   // called. Virtual for mocking.
-  virtual void Initialize(PrefService* local_prefs,
-                          DeviceManagementService* service,
+  virtual void Initialize(PrefService* local_state,
+                          DeviceManagementService* device_management_service,
                           UserAffiliation user_affiliation);
 
   // Shuts down the UserCloudPolicyManager (removes and stops refreshing the
   // cached cloud policy). This is typically called when a profile is being
   // disassociated from a given user (e.g. during signout). No policy will be
   // provided by this object until the next time Initialize() is invoked.
   void ShutdownAndRemovePolicy();
 
   // Cancels waiting for the policy fetch and flags the
   // ConfigurationPolicyProvider ready (assuming all other initialization tasks
   // have completed).
   void CancelWaitForPolicyFetch();
 
   // Returns true if the underlying CloudPolicyClient is already registered.
   // Virtual for mocking.
   virtual bool IsClientRegistered() const;
 
   // Register the CloudPolicyClient using the passed OAuth token.
   void RegisterClient(const std::string& access_token);

[Joao da Silva, 2012/09/07 12:44:13]

#include <string>

[Mattias Nissler (ping if slow), 2012/09/07 13:12:59]

Done.

 
-  CloudPolicyService* cloud_policy_service() { return service_.get(); }
-
   // ConfigurationPolicyProvider:
   virtual bool IsInitializationComplete() const OVERRIDE;
-  virtual void RefreshPolicies() OVERRIDE;
 
   // CloudPolicyClient::Observer:
   virtual void OnPolicyFetched(CloudPolicyClient* client) OVERRIDE;
   virtual void OnRegistrationStateChanged(CloudPolicyClient* client) OVERRIDE;
   virtual void OnClientError(CloudPolicyClient* client) OVERRIDE;
 
-  // CloudPolicyStore::Observer:
-  virtual void OnStoreLoaded(CloudPolicyStore* store) OVERRIDE;
-  virtual void OnStoreError(CloudPolicyStore* store) OVERRIDE;
-
  private:
-  // Check whether fully initialized and if so, publish policy by calling
-  // ConfigurationPolicyStore::UpdatePolicy().
-  void CheckAndPublishPolicy();
-
   // Completion handler for the explicit policy fetch triggered on startup in
   // case |wait_for_policy_fetch_| is true.
   void OnInitialPolicyFetchComplete();
 
-  // Completion handler for policy refresh operations.
-  void OnRefreshComplete();
-
-  // Frees the CloudPolicyService and stops refreshing policy. Any previously
-  // cached policy will continue to be served.
-  void Shutdown();
-
   // Whether to wait for a policy fetch to complete before reporting
   // IsInitializationComplete().
   bool wait_for_policy_fetch_;
 
-  // Whether there's a policy refresh operation pending, in which case all
-  // policy update notifications are deferred until after it completes.
-  bool wait_for_policy_refresh_;
-
-  scoped_ptr<CloudPolicyStore> store_;
-  scoped_ptr<CloudPolicyService> service_;
-  scoped_ptr<CloudPolicyRefreshScheduler> refresh_scheduler_;
-
   // The pref service to pass to the refresh scheduler on initialization.
-  PrefService* prefs_;
+  PrefService* local_state_;
 
   DISALLOW_COPY_AND_ASSIGN(UserCloudPolicyManager);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_POLICY_USER_CLOUD_POLICY_MANAGER_H_